Allow access and dual access together #962
Open
+61
−36
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support creating both types of accessibility analysis in a single regional analysis in the future.
These changes accomplish this by:
{id}_{destinationsId}_p{percentile}.access
to{id}_{destinationsId}_p{percentile}.dual.access
so the names do not clash with regular accessibility results (a similar change is applied to the derived single threshold grid files).dualAccessValues
parameter toRegionalWorkResult
so that theaccessibilityValues
parameter is not overwritten with dual access values.Notably, this does not require any UI changes at this time. The staging UI currently only allows creating one type at a time. When viewing results,
getRegionalResults
retrieves a single type depending on how it was created. Once the UI allows it in the future, we can add a query parameter togetRegionalResults
to select between the different results.