Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow access and dual access together #962

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

Conversation

trevorgerhardt
Copy link
Member

@trevorgerhardt trevorgerhardt commented Apr 5, 2025

Support creating both types of accessibility analysis in a single regional analysis in the future.

These changes accomplish this by:

  1. Changing dual access filenames from {id}_{destinationsId}_p{percentile}.access to {id}_{destinationsId}_p{percentile}.dual.access so the names do not clash with regular accessibility results (a similar change is applied to the derived single threshold grid files).
  2. Adding a dualAccessValues parameter to RegionalWorkResult so that the accessibilityValues parameter is not overwritten with dual access values.

Notably, this does not require any UI changes at this time. The staging UI currently only allows creating one type at a time. When viewing results, getRegionalResults retrieves a single type depending on how it was created. Once the UI allows it in the future, we can add a query parameter to getRegionalResults to select between the different results.

Support both types of accessibility analysis in a single regional analysis
@trevorgerhardt trevorgerhardt marked this pull request as ready for review April 7, 2025 15:56
@trevorgerhardt trevorgerhardt requested a review from ansoncfit April 7, 2025 15:57
@trevorgerhardt trevorgerhardt enabled auto-merge (rebase) April 7, 2025 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant