-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI:BUILD] rpm: remove dnsname #20790
Conversation
With CNI going away in v5, there's no need for dnsname in the rpm. [NO NEW TESTS NEEDED] Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lsm5 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes end up in podman-next once merged, right?
Is there anything to consider when removing a package? I think it might be better to hold this until we have the CNI build tag work done and disable it on default builds. Only then we should merge this as for now CNI will still work with the podman-next copr.
Unless there is a reason to do it now?
Yes
In this particular case, podman-plugins isn't really affecting any other package. So it can be left alone and we can ask users to manually uninstall it and move on. If we wanna
sgtm
no, this can wait. |
containers/common#1767 is vendored into podman main branch, so I think we can go ahead with this one. |
@ashley-cui @Luap99 remind me please, given that we're not doing podman 5 on F 38/39, do we need to care about enabling cni buildtag in the copr build tasks in CI as well as on |
#21410 was just merged so this here should be good to go We do not want to enable cni for 5.0, this will only be done for RHEL 9 AFAIK so we do not break users there. For upstream builds we really do not want to continue to support CNI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/lgtm |
/hold cancel |
With CNI going away in v5, there's no need for dnsname in the rpm.
[NO NEW TESTS NEEDED]
Does this PR introduce a user-facing change?