Skip to content
This repository has been archived by the owner on Jul 25, 2024. It is now read-only.

Persist submitting user metadata #160

Merged
merged 1 commit into from
May 8, 2024
Merged

Conversation

sc15zs
Copy link
Contributor

@sc15zs sc15zs commented May 2, 2024

Ticket:
https://dluhcdigital.atlassian.net/browse/FMD-251

Description:
On submission passes user's account_id and email address to data-store/ingest.

DEBUG_USER_ACCOUNT_ID is added to config/envs/development.py to be able to test locally.

Copy link
Contributor

@Joel-Pearce Joel-Pearce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest writing a unit test to assert that the metadata is successfully extracted from the g class and sent to the backend. It can be written with a mocked user, much as we have done for our authorisation tests.

@sc15zs
Copy link
Contributor Author

sc15zs commented May 7, 2024

I suggest writing a unit test to assert that the metadata is successfully extracted from the g class and sent to the backend. It can be written with a mocked user, much as we have done for our authorisation tests.

As discussed, there's not much we could test in submit, so there are no tests here.
Unit test has been added to the data-store to make sure submitted values are successfully saved on Submission model.

@sc15zs sc15zs force-pushed the persist_submitting_user_metadata branch from 9759fdd to d9d2317 Compare May 7, 2024 14:42
@sc15zs sc15zs force-pushed the persist_submitting_user_metadata branch from d9d2317 to 139a912 Compare May 7, 2024 16:55
@samuelhwilliams samuelhwilliams dismissed Joel-Pearce’s stale review May 8, 2024 09:33

test has been added

@sc15zs sc15zs merged commit 2c24a72 into main May 8, 2024
2 checks passed
@sc15zs sc15zs deleted the persist_submitting_user_metadata branch May 8, 2024 15:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants