Merge pull request #142 from communitiesuk/SMD-697/fe-id-tags

[SMD-697] ID tags for testing
communitiesuk · May 24, 2024 · 6d4262a · 6d4262a
2 parents 7cf98fe + 88cc1aa
commit 6d4262a
Show file tree

Hide file tree

Showing 4 changed files with 18 additions and 12 deletions.
diff --git a/app/templates/main/dashboard.html b/app/templates/main/dashboard.html
@@ -20,7 +20,7 @@ <h2 class="govuk-heading-m">All funds ({{ authorised_funds | length }})</h2>
 
                       <div class="govuk-summary-list__row">
                         <dt class="govuk-summary-list__key">
-                            <a class="govuk-heading-m govuk-link--no-visited-state" href={{ url_for('main.upload', fund_code=fund_code, round=fund.current_reporting_round) }}> {{ fund.fund_name }}</a>
+                            <a class="govuk-heading-m govuk-link--no-visited-state" id="{{ fund_code }}"href={{ url_for('main.upload', fund_code=fund_code, round=fund.current_reporting_round) }}> {{ fund.fund_name }}</a>
                             <p class="govuk-body"><b>Local Authority</b></p>
                             <p class="govuk-body"><b>Reporting Period</b></p>
                         </dt>

diff --git a/app/templates/main/upload.html b/app/templates/main/upload.html
@@ -71,7 +71,8 @@
 
                 {{ govukButton({
                     "element": "button",
-                    "text": "Upload and check for errors"})
+                    "text": "Upload and check for errors",
+                    "id":"upload-button"})
                 }}
             </form>
             {{ helpLinksDropdown() }}

diff --git a/app/templates/main/validation-errors.html b/app/templates/main/validation-errors.html
@@ -34,7 +34,8 @@ <h2 class="govuk-heading-l">Errors fixed?</h2>
 
             {{ govukButton({
                 "element": "button",
-                "text": "Upload and check for errors"})
+                "text": "Upload and check for errors",
+                "id":"upload-button"})
             }}
 
         </form>

diff --git a/tests/test_routes.py b/tests/test_routes.py
@@ -21,11 +21,12 @@ def test_select_fund_page_with_tf_role(flask_test_client, mocker):
     response = flask_test_client.get("/dashboard")
     page_html = BeautifulSoup(response.data)
     assert response.status_code == 200
-    assert '<a class="govuk-heading-m govuk-link--no-visited-state" href="/upload/TF/5"> Towns Fund</a>' in str(
+    assert '<a class="govuk-heading-m govuk-link--no-visited-state" href="/upload/TF/5" id="TF"> Towns Fund</a>' in str(
         page_html
     )
-    assert '<a class="govuk-heading-m govuk-link--no-visited-state" href="/upload/PF/1"> Pathfinders</a>' not in str(
-        page_html
+    assert (
+        '<a class="govuk-heading-m govuk-link--no-visited-state" href="/upload/PF/1" id="PF"> Pathfinders</a>'
+        not in str(page_html)
     )
 
 
@@ -34,10 +35,12 @@ def test_select_fund_page_with_pf_role(flask_test_client, mocked_pf_auth):
     assert response.status_code == 200
     page_html = BeautifulSoup(response.data)
     assert (
-        '<a class="govuk-heading-m govuk-link--no-visited-state" href="/upload/TF/5"> Towns Fund</a>' not in page_html
+        '<a class="govuk-heading-m govuk-link--no-visited-state" href="/upload/TF/5" id="TF"> Towns Fund</a>'
+        not in page_html
     )
-    assert '<a class="govuk-heading-m govuk-link--no-visited-state" href="/upload/PF/1"> Pathfinders</a>' in str(
-        page_html
+    assert (
+        '<a class="govuk-heading-m govuk-link--no-visited-state" href="/upload/PF/1" id="PF"> Pathfinders</a>'
+        in str(page_html)
     )
 
 
@@ -46,11 +49,12 @@ def test_select_fund_page_with_tf_and_pf_roles(flask_test_client, mocked_pf_and_
     response = flask_test_client.get("/dashboard")
     page_html = BeautifulSoup(response.data)
     assert response.status_code == 200
-    assert '<a class="govuk-heading-m govuk-link--no-visited-state" href="/upload/TF/5"> Towns Fund</a>' in str(
+    assert '<a class="govuk-heading-m govuk-link--no-visited-state" href="/upload/TF/5" id="TF"> Towns Fund</a>' in str(
         page_html
     )
-    assert '<a class="govuk-heading-m govuk-link--no-visited-state" href="/upload/PF/1"> Pathfinders</a>' in str(
-        page_html
+    assert (
+        '<a class="govuk-heading-m govuk-link--no-visited-state" href="/upload/PF/1" id="PF"> Pathfinders</a>'
+        in str(page_html)
     )