This repository has been archived by the owner on Oct 28, 2024. It is now read-only.
Fs 3060 add freetextfield to designer #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…b.com/communitiesuk/digital-form-builder into fs-3060-add-freetextfield-to-designer
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FS-3060 Add FreeTextField component type to designer
Updated the freetextfield model to remove min/max lengths as we don't use these
Updated tests as per the above
Added FreeTextField to component types and created edit screen in designer, using MultilineTextField as an example.
Updated unit tests for the component list to include free text field
Tested in the designer locally, both generating a form, downloading it and opening in the runner, and also importing a DPIF form that uses FreeTextField
Note: DIscovered that the tests in
designer/testaren't currently runnable, probably due to missing dependencies. Doesn't look like they have ever run - they are executed in the pipeline but they fail and then the pipeline passes anyway. @SophieOHagan99 is addressing these along with fixing the smoke tests under FS-3456Screenshots