-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hasWarning
prop is not supported in many<*Input>
components
#2671
Comments
Just for transparency, I'll write this here. It was decided that
@commercetools/pacman-team-fe will work on implementing this. |
hasWarning
prop is not supported in many<*Field>
componentshasWarning
prop is not supported in many<*Input>
components
Hi @jaikumar-tj, I see your team has started working on this issue. Will your team be handling it all the way through? Thanks! |
Hi @chloe0592 Yes, the final PR for this is here: #2698 |
Hi @chloe0592, Please let us know if we need to do anything else other than what Chisom commented. We are not sure about all the procedures. |
@obulaworld can we close this ticket or is there anything pending? |
We can close it now. Nothing is pending |
Is your feature request related to a problem? Please describe.
Not all the Field components support the orange border when we want to display warning
Describe the solution you'd like

Some components like
SelectField
accepts thehasWarning
props but the other field components likeTextField, MoneyField, etc
don't have the same propPacman Team and Context Team have an upcoming feature that requires this feature in order to be implemented it in the MC. Otherwise, we have to get rid of the
Field
component and use theInput
&Text
components (i.e, replacing<TextField>
from product detail page and use<TextInput>
and<Text.Body>
to achieve the same result) which seems like going against the idea of using the existing components.@AnjaBuerger , @mariabarrena and @FilPob already discussed and agreed on this.
Ideally all the

<*Field>
components should havehasWarning
featureNote: We(@commercetools/pacman-team-fe) were originally planning to contribute to the UI-kit repo in the next Q during our feature development stage to enable this feature. If we get any early support from @commercetools/shield-team-fe or @commercetools/context-team-fe that would be much appreciated as well
The text was updated successfully, but these errors were encountered: