Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: create FieldWarnings component and update FieldErrors #2686

Merged
merged 9 commits into from
Jan 17, 2024

Conversation

obulaworld
Copy link
Contributor

Summary

Create FieldWarnings component and Add FieldErrors Story.
It seeks to partially fix this UI-KIT issue

Description

This PR seeks to create FieldWarnings component by:

  • Adding a FieldWarnings component to UI-KIT
  • Additionally adding FieldErrors Story.

Screenshots

Screenshot 2024-01-15 at 23 17 31 Screenshot 2024-01-15 at 23 17 41 Screenshot 2024-01-15 at 23 17 48 Screenshot 2024-01-15 at 23 17 55

Copy link

changeset-bot bot commented Jan 15, 2024

🦋 Changeset detected

Latest commit: 91ba20f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 94 packages
Name Type
@commercetools-uikit/messages Major
@commercetools-uikit/field-warnings Major
@commercetools-uikit/field-errors Major
@commercetools-uikit/localized-multiline-text-input Major
@commercetools-uikit/localized-rich-text-input Major
@commercetools-uikit/localized-text-input Major
@commercetools-frontend/ui-kit Major
@commercetools-uikit/async-creatable-select-field Major
@commercetools-uikit/async-select-field Major
@commercetools-uikit/creatable-select-field Major
@commercetools-uikit/date-field Major
@commercetools-uikit/date-range-field Major
@commercetools-uikit/date-time-field Major
@commercetools-uikit/localized-multiline-text-field Major
@commercetools-uikit/localized-text-field Major
@commercetools-uikit/money-field Major
@commercetools-uikit/multiline-text-field Major
@commercetools-uikit/number-field Major
@commercetools-uikit/password-field Major
@commercetools-uikit/radio-field Major
@commercetools-uikit/search-select-field Major
@commercetools-uikit/select-field Major
@commercetools-uikit/text-field Major
@commercetools-uikit/time-field Major
@commercetools-uikit/inputs Major
@commercetools-uikit/fields Major
@commercetools-uikit/design-system Major
@commercetools-uikit/calendar-time-utils Major
@commercetools-uikit/calendar-utils Major
@commercetools-uikit/hooks Major
@commercetools-uikit/i18n Major
@commercetools-uikit/localized-utils Major
@commercetools-uikit/utils Major
@commercetools-uikit/accessible-hidden Major
@commercetools-uikit/avatar Major
@commercetools-uikit/card Major
@commercetools-uikit/collapsible-motion Major
@commercetools-uikit/collapsible-panel Major
@commercetools-uikit/collapsible Major
@commercetools-uikit/constraints Major
@commercetools-uikit/data-table-manager Major
@commercetools-uikit/data-table Major
@commercetools-uikit/field-label Major
@commercetools-uikit/grid Major
@commercetools-uikit/icons Major
@commercetools-uikit/label Major
@commercetools-uikit/link Major
@commercetools-uikit/loading-spinner Major
@commercetools-uikit/notifications Major
@commercetools-uikit/pagination Major
@commercetools-uikit/primary-action-dropdown Major
@commercetools-uikit/stamp Major
@commercetools-uikit/tag Major
@commercetools-uikit/text Major
@commercetools-uikit/tooltip Major
@commercetools-uikit/view-switcher Major
@commercetools-uikit/accessible-button Major
@commercetools-uikit/flat-button Major
@commercetools-uikit/icon-button Major
@commercetools-uikit/link-button Major
@commercetools-uikit/primary-button Major
@commercetools-uikit/secondary-button Major
@commercetools-uikit/secondary-icon-button Major
@commercetools-uikit/async-creatable-select-input Major
@commercetools-uikit/async-select-input Major
@commercetools-uikit/checkbox-input Major
@commercetools-uikit/creatable-select-input Major
@commercetools-uikit/date-input Major
@commercetools-uikit/date-range-input Major
@commercetools-uikit/date-time-input Major
@commercetools-uikit/input-utils Major
@commercetools-uikit/localized-money-input Major
@commercetools-uikit/money-input Major
@commercetools-uikit/multiline-text-input Major
@commercetools-uikit/number-input Major
@commercetools-uikit/password-input Major
@commercetools-uikit/radio-input Major
@commercetools-uikit/rich-text-input Major
@commercetools-uikit/rich-text-utils Major
@commercetools-uikit/search-select-input Major
@commercetools-uikit/search-text-input Major
@commercetools-uikit/select-input Major
@commercetools-uikit/select-utils Major
@commercetools-uikit/selectable-search-input Major
@commercetools-uikit/text-input Major
@commercetools-uikit/time-input Major
@commercetools-uikit/toggle-input Major
@commercetools-uikit/spacings-inline Major
@commercetools-uikit/spacings-inset-squish Major
@commercetools-uikit/spacings-inset Major
@commercetools-uikit/spacings-stack Major
@commercetools-uikit/buttons Major
@commercetools-uikit/spacings Major
visual-testing-app Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jan 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ui-kit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 17, 2024 3:11pm

@obulaworld obulaworld marked this pull request as ready for review January 16, 2024 12:52
@obulaworld obulaworld requested a review from a team January 16, 2024 12:52
@obulaworld obulaworld self-assigned this Jan 16, 2024
@obulaworld obulaworld added the 🙏 Status: Dev Review Waiting for technical reviews label Jan 16, 2024
Co-authored-by: Carlos Cortizas <97907068+CarlosCortizasCT@users.noreply.github.com>
Copy link
Contributor

@CarlosCortizasCT CarlosCortizasCT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

Thanks for your contribution 👏

Copy link
Contributor

@ddouglasz ddouglasz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Asides a small observation, everything looks good to me.
Thanks for working on this 🙌🏽

obulaworld and others added 2 commits January 17, 2024 16:07
Co-authored-by: Douglas Egiemeh <douglasegiemeh@gmail.com>
Co-authored-by: Douglas Egiemeh <douglasegiemeh@gmail.com>
@ddouglasz ddouglasz merged commit b80555d into main Jan 17, 2024
6 checks passed
@ddouglasz ddouglasz deleted the co-create-field-warnings-component branch January 17, 2024 15:16
@ct-changesets ct-changesets bot mentioned this pull request Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🙏 Status: Dev Review Waiting for technical reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants