Use str_ends_with function over strpos to fix false notice #1036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah - brilliant! Test fails are due to civicrm.org extensions dir not running at the moment. Going to merge that - then rebase this. |
|
Thank you @KarinG |
|
I have one project with a custom_692 - so it was easy to test :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
When deleting a custom field, the UI erroneously displays the message “This field is used in the following webforms:” even when the field isn't actually used.
This issue arises in rare scenarios where there are over 100 custom fields in the system. For example, if a webform includes the field custom_354 and you attempt to delete custom_35, the warning appears because the code mistakenly matches the substring custom_35 within identifiers like civicrm_1_contact_1_cg42_custom_358 or civicrm_1_contact_1_cg42_custom_359. This PR resolves the issue by using the str_ends_with function for precise matching.