Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Wallet Advanced Send (Fund Wallet) #2075

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

brendan-defi
Copy link
Contributor

@brendan-defi brendan-defi commented Mar 4, 2025

What changed? Why?

  • Updated WalletAdvanced's Send button to use native Send flow instead of opening wallet.coinbase.com
  • Added top-level Send component
  • Implemented logic for first step of Send flow:
    • if connected wallet has insufficient ETH balance, they are shown SendFundWallet
    • if connected wallet has sufficient ETH, they are shown a placeholder

Notes to reviewers

How has it been tested?

  • test coverage
  • in playground a connected wallet should show
    • SendFundWallet if it has less than 0.000001 ETH
    • a placeholder message if it has more than 0.000001 ETH

Copy link

vercel bot commented Mar 4, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
onchainkit-coverage ❌ Failed (Inspect) Mar 4, 2025 8:29pm
onchainkit-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 4, 2025 8:29pm
onchainkit-routes ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 4, 2025 8:29pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant