feat: update go sdk generated code with strict decoder disabled #50
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
With some recent CDP API backend changes, it was observed that adding new fields to api responses seems to break the go client and returns error of typically this format.
This happens even when fields are marked optional.
This error can be attributed to strict json decoding that the client applies by default. Example code here.
This PR helps regenerate the go auto-generate client with this setting
disallowAdditionalPropertiesIfNotPresent
set tofalse
. This helps remove this strict decoder check. Config option description can be found here and a github issue discussing this issue.Testing
Verified running example scripts
examples/ethereum/dedicated-eth-stake/main.go
andexamples/ethereum/shared-eth-stake/main.go
Qualified Impact