Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Search Feature of Skills cirteria implement from one skill to mutliple Skills #414

Merged
merged 4 commits into from
Oct 24, 2024

Conversation

Sambashivarao-Boyina
Copy link
Contributor

… search and working very well and there is not errors. Also it is adaptable with dark mode

Description

I have the changed the search feature when criteria is skill form single skill to multiple skills now use can filter profiles based on multiple skills . if any user matches any single skill in given skills set it will be showed

after we can remove the each skill and clear all the skills

Related Issues

This is the Issue, I have raised in issues box #330
It is under gssoc-ext , hacktoberfest2024

Changes Proposed

Before the the changes it does not able to filter profiles when we enter multiple skills

Screenshot from 2024-10-19 17-30-41

Now
when a user enters any skill and clicks enter, it will be added to the searchSkills list and after that, we can enter multiple skills by entering in the textbox and clicking enter. we can also remove them one by one also

Screenshot from 2024-10-24 15-20-30

Screenshot from 2024-10-24 15-20-41

It also supports dark theme also

Screenshot from 2024-10-24 15-20-50

Is also supported on all screens

Checklist

  • I have read and followed the Contribution Guidelines.
  • All new and existing tests passed.
  • I have updated the documentation to reflect the changes I've made.
  • My code follows the code style of this project.
  • The title of my pull request is a short description of the requested changes.

Note to reviewers

I have changed the logic in the Homepage I separate the filter logic of criteria of skill with the remaining and write a new logic I have the shuffledProfiles for filter data if I clear the skills I set the shuffledProfiles

I have tested the code in all ways it working properly. I didn't see any errors

If my code satisfied your standards and if my code is valid and working properly. please merge the code and also add the badges of gssoc-ext , hacktoberfest2024.

Thank you

… search and working very well and there is not errors. Also it is adaptable with dark mode
Copy link

vercel bot commented Oct 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
devdisplay ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2024 4:07pm

Copy link

netlify bot commented Oct 24, 2024

Deploy Preview for devdisplay failed.

Name Link
🔨 Latest commit 4a4e6da
🔍 Latest deploy log https://app.netlify.com/sites/devdisplay/deploys/671a709de039dc0008c44233

@codeaashu codeaashu self-requested a review October 24, 2024 16:07
@madhukalita madhukalita requested review from madhukalita and removed request for codeaashu October 24, 2024 16:07
@madhukalita madhukalita added hacktoberfest Label is used for Issues and pull request related to Hacktoberfest 2024 open source contribution. hacktoberfest2024 Label for tracking contributions and activities during Hacktoberfest 2024 gssoc24 opensource Label is used for Issues and pull request related to all open source contribution. hacktoberfest-accepted Label is used for accept the pull request of contributer in Hacktoberfest 2024. labels Oct 24, 2024
@madhukalita madhukalita merged commit 530f35c into codeaashu:main Oct 24, 2024
3 of 7 checks passed
@codeaashu codeaashu requested review from codeaashu and madhukalita and removed request for madhukalita and codeaashu October 24, 2024 16:09
@Sambashivarao-Boyina
Copy link
Contributor Author

Thank You for accepting my code

@madhukalita
Copy link
Collaborator

Join DevDisplay Whatsapp community
for future update on this and also for upcoming project collabration through DevDisplay Community
https://chat.whatsapp.com/Dcl21sgGDIpHURESSuH0p4

@madhukalita
Copy link
Collaborator

hayy @Sambashivarao-Boyina
one task for u

checkout the latest PR #386

Add voice search functionality in search

@Sambashivarao-Boyina
Copy link
Contributor Author

Sambashivarao-Boyina commented Oct 26, 2024

hayy @Sambashivarao-Boyina one task for u

checkout the latest PR #386

Add voice search functionality in search

Yes, I will do this.

could you assign this to me .

I have raised an issue of this in issues box #432 could you please assign this to me under gssoc-ext, hacktober-fest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest Label is used for Issues and pull request related to Hacktoberfest 2024 open source contribution. hacktoberfest2024 Label for tracking contributions and activities during Hacktoberfest 2024 hacktoberfest-accepted Label is used for accept the pull request of contributer in Hacktoberfest 2024. opensource Label is used for Issues and pull request related to all open source contribution.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants