Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDPCP-14126 - GH action jobs are getting triggered once a PR is landed on the main even though it is not necessary #218

Merged
merged 1 commit into from
Feb 24, 2025

Conversation

gregito
Copy link
Contributor

@gregito gregito commented Feb 24, 2025

GH action jobs under the .github/workflows/test.yml are getting triggered even though all the jobs should've been run on the designated PR (since no direct push is allowed to the main branch).

This is not just unnecessary resource usage, but since some jobs can be branch-specific (such as the commit count checker job that can be run only on branches that are not the main) this means these jobs shall fail and would confuse the readers of the repo.

…d on the main even though it is not necessary
@gregito gregito requested a review from a team as a code owner February 24, 2025 17:22
@gregito gregito enabled auto-merge (rebase) February 24, 2025 17:23
Copy link

Go test coverage: 35.5% for commit 20db80d
⚠️ 2 of 17 packages have zero coverage.
  • github.com/cloudera/terraform-provider-cdp/resources/de
  • github.com/cloudera/terraform-provider-cdp/resources/ml
View coverage for all packages
# Package Name                                                                    | Coverage
+ github.com/cloudera/terraform-provider-cdp/cdpacctest                           |    14.3%
+ github.com/cloudera/terraform-provider-cdp/provider                             |    78.7%
+ github.com/cloudera/terraform-provider-cdp/resources/datahub                    |    35.8%
+ github.com/cloudera/terraform-provider-cdp/resources/datalake                   |     9.2%
- github.com/cloudera/terraform-provider-cdp/resources/de                         |     0.0%
+ github.com/cloudera/terraform-provider-cdp/resources/dw/cluster/aws             |    71.9%
+ github.com/cloudera/terraform-provider-cdp/resources/dw/databasecatalog         |    65.8%
+ github.com/cloudera/terraform-provider-cdp/resources/dw/dataviz                 |    78.0%
+ github.com/cloudera/terraform-provider-cdp/resources/dw/virtualwarehouse/hive   |    77.7%
+ github.com/cloudera/terraform-provider-cdp/resources/dw/virtualwarehouse/impala |    70.2%
+ github.com/cloudera/terraform-provider-cdp/resources/environments               |    44.4%
+ github.com/cloudera/terraform-provider-cdp/resources/iam                        |     2.7%
- github.com/cloudera/terraform-provider-cdp/resources/ml                         |     0.0%
+ github.com/cloudera/terraform-provider-cdp/resources/opdb                       |    25.4%
+ github.com/cloudera/terraform-provider-cdp/resources/recipe                     |    12.0%
+ github.com/cloudera/terraform-provider-cdp/utils                                |    56.1%
+ github.com/cloudera/terraform-provider-cdp/utils/test                           |    75.0%

@gregito gregito merged commit 64be974 into main Feb 24, 2025
15 checks passed
@gregito gregito deleted the CDPCP-14126 branch February 24, 2025 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants