Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Docker registry references from docker.cloudentity.io to docker.secureauth.com #312

Merged
merged 4 commits into from
Jan 15, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/update-helm-chart-faas-images.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ jobs:
echo "REGO_V6=${{ github.event.inputs.rego_v6 }}" >> $GITHUB_ENV
echo "TAG=${{ github.event.inputs.tag }}" >> $GITHUB_ENV
- name: Docker Registry Login
run: echo "${{ secrets.PUBLIC_DOCKER_CLOUDENTITY_REPO_DEV_PASSWORD }}" | docker login docker.cloudentity.io -u "${{ secrets.PUBLIC_DOCKER_CLOUDENTITY_REPO_DEV_USERNAME }}" --password-stdin
run: echo "${{ secrets.PUBLIC_DOCKER_CLOUDENTITY_REPO_DEV_PASSWORD }}" | docker login docker.secureauth.com -u "${{ secrets.PUBLIC_DOCKER_CLOUDENTITY_REPO_DEV_USERNAME }}" --password-stdin
- name: Update Helm Values File
shell: bash
run: |
Expand All @@ -47,7 +47,7 @@ jobs:
if [ "$update" = "true" ]; then
version=${env##*_}
component=${env%%_*}
image=docker.cloudentity.io/${component,,}-env:${version,,}-$TAG
image=docker.secureauth.com/${component,,}-env:${version,,}-$TAG
yq ".faas.environments.${component,,}.${version,,}.image = \"${image}\"" charts/acp/values.yaml > values.updated
yq "." charts/acp/values.yaml | diff -B - values.updated | patch charts/acp/values.yaml - || true
rm -f values.updated charts/acp/values.yaml.orig
Expand Down
4 changes: 2 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,9 @@ create-cluster:
--name acp-helm-charts \
--config tests/config/kind.yaml
kubectl create namespace ${NAMESPACE}
kubectl create secret docker-registry docker.cloudentity.io \
kubectl create secret docker-registry docker.secureauth.com \
--namespace ${NAMESPACE} \
--docker-server=docker.cloudentity.io \
--docker-server=docker.secureauth.com \
--docker-username=${DOCKER_USER} \
--docker-password=${DOCKER_PWD}

Expand Down
2 changes: 1 addition & 1 deletion charts/acp-cd/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@ apiVersion: v2
name: acp-cd
description: Cloudentity ACP continuous Delivery
type: application
version: 2.23.0
version: 2.23.1
appVersion: "2.23.0"
2 changes: 1 addition & 1 deletion charts/acp-cd/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -70,5 +70,5 @@ Istio authorizer defines Pod that uses a Secret to pull an image from a private
To manually configure Docker credentials, first create a Secret by providing credentials on the command line:

```console
kubectl create secret docker-registry docker.cloudentity.io --docker-server=docker.cloudentity.io --docker-username=<your-name> --docker-password=<your-password>
kubectl create secret docker-registry docker.secureauth.com --docker-server=docker.secureauth.com --docker-username=<your-name> --docker-password=<your-password>
```
4 changes: 2 additions & 2 deletions charts/acp-cd/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
image:
## Image repository
##
repository: docker.cloudentity.io/acp-distroless
repository: docker.secureauth.com/acp-distroless

## Image pull policy
##
Expand All @@ -16,7 +16,7 @@ image:
## Global Docker registry secret names as an array
##
imagePullSecrets:
- name: docker.cloudentity.io
- name: docker.secureauth.com

## String to partially override acp.name
##
Expand Down
2 changes: 1 addition & 1 deletion charts/acp/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@ apiVersion: v2
name: acp
description: Cloudentity Authorization Control Plane
type: application
version: 2.23.1
version: 2.23.2
appVersion: "2.23.0"
8 changes: 7 additions & 1 deletion charts/acp/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,12 @@ $ helm upgrade [RELEASE_NAME] [CHART] --install

_See [helm upgrade](https://helm.sh/docs/helm/helm_upgrade/) for command documentation._

### From 2.23.1 to 2.23.2

Version 2.23.2 of ACP helm chart uses `docker.secureauth.com` as the secret name referencing SecureAuth registry.
If you're using the `docker.cloudentity.io` and haven't overridden `imagePullSecrets` before, you have to create a new secret with the name `docker.secureauth.com`
See [Docker Pull Credentials](#docker-pull-credentials).

### Update to 2.21.0

* Support for docker faas envs has beed added at `faas.environments`
Expand Down Expand Up @@ -173,7 +179,7 @@ Fission environment defines Pod that uses a Secret to pull an image from a priva
To manually configure Docker credentials, first create a Secret by providing credentials on the command line:

```console
kubectl create secret -n <faas.namespace> docker-registry docker.cloudentity.io --docker-server=docker.cloudentity.io --docker-username=<your-name> --docker-password=<your-password>
kubectl create secret -n <faas.namespace> docker-registry docker.secureauth.com --docker-server=docker.secureauth.com --docker-username=<your-name> --docker-password=<your-password>
```

> **Note**: `faas.namespace` can be defined in [values.yaml](./values.yaml):
Expand Down
14 changes: 7 additions & 7 deletions charts/acp/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
image:
## Image repository
##
repository: docker.cloudentity.io/acp-distroless
repository: docker.secureauth.com/acp-distroless

## Image pull policy
##
Expand All @@ -16,7 +16,7 @@ image:
## Global Docker registry secret names as an array
##
imagePullSecrets:
- name: docker.cloudentity.io
- name: docker.secureauth.com

## Public ACP URL
##
Expand Down Expand Up @@ -628,7 +628,7 @@ faas:

## Environment image
##
image: docker.cloudentity.io/node-env:v4-20241212-064355-0d923fba
image: docker.secureauth.com/node-env:v4-20241212-064355-0d923fba

## Environment expiration date
##
Expand All @@ -645,7 +645,7 @@ faas:

## Environment image
##
image: docker.cloudentity.io/node-env:v5-20241212-064355-0d923fba
image: docker.secureauth.com/node-env:v5-20241212-064355-0d923fba

## Environment expiration date
##
Expand All @@ -662,7 +662,7 @@ faas:

## Environment image
##
image: docker.cloudentity.io/node-env:v6-20241212-064355-0d923fba
image: docker.secureauth.com/node-env:v6-20241212-064355-0d923fba

## Environment expiration date
##
Expand All @@ -680,7 +680,7 @@ faas:

## Environment image
##
image: docker.cloudentity.io/rego-env:v6-20250114-112120-54d42910
image: docker.secureauth.com/rego-env:v6-20250114-112120-54d42910

## Environment expiration date
##
Expand All @@ -704,7 +704,7 @@ faas:
## Docker registry secret name
##
imagePullSecrets:
- name: docker.cloudentity.io
- name: docker.secureauth.com

## Array with environment variables to add to the container
##
Expand Down
2 changes: 1 addition & 1 deletion charts/istio-authorizer/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@ apiVersion: v2
name: istio-authorizer
description: A Helm chart for istio-authorizer
type: application
version: 2.23.0
version: 2.23.1
appVersion: "2.23.0"
6 changes: 6 additions & 0 deletions charts/istio-authorizer/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,12 @@ $ helm upgrade [RELEASE_NAME] [CHART] --install

_See [helm upgrade](https://helm.sh/docs/helm/helm_upgrade/) for command documentation._

### From 2.23.0 to 2.23.1

Version 2.23.1 of istio authorizer helm chart uses `docker.secureauth.com` as the secret name referencing SecureAuth registry.
If you're using the `docker.cloudentity.io` and haven't overridden `imagePullSecrets` before, you have to create a new secret with the name `docker.secureauth.com`
See [Docker Pull Credentials](#docker-pull-credentials).

### From 1.15.0 to 1.15.1

Version 1.15.1 of istio authorizer helm chart uses `docker.cloudentity.io` as the secret name referencing Cloudentity registry.
Expand Down
2 changes: 1 addition & 1 deletion charts/istio-authorizer/templates/dockerregistry.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,6 @@ apiVersion: v1
kind: Secret
type: kubernetes.io/dockerconfigjson
metadata:
name: docker.cloudentity.io
name: docker.secureauth.com
data:
.dockerconfigjson: eyJhdXRocyI6eyJkb2NrZXIuY2xvdWRlbnRpdHkuaW8iOnsidXNlcm5hbWUiOiJhdXRob3JpemVycyIsInBhc3N3b3JkIjoiek0zRjMzSWZWWWx5Q3BCZUVpUkxYN0tpc0RHU2plUVkiLCJhdXRoIjoiWVhWMGFHOXlhWHBsY25NNmVrMHpSak16U1daV1dXeDVRM0JDWlVWcFVreFlOMHRwYzBSSFUycGxVVms9In19fQ==
4 changes: 2 additions & 2 deletions charts/istio-authorizer/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
image:
## Image repository
##
repository: docker.cloudentity.io/istio-authorizer
repository: docker.secureauth.com/istio-authorizer

## Image pull policy
##
Expand Down Expand Up @@ -48,7 +48,7 @@ podAnnotations: []
## istio-authorizer image registry secret names as an array
##
imagePullSecrets:
- name: docker.cloudentity.io
- name: docker.secureauth.com

## Pod security context
##
Expand Down
4 changes: 2 additions & 2 deletions charts/kube-acp-stack/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v2
name: kube-acp-stack
description: kube-acp-stack collects acp charts combined with documentation and scripts to provide easy to operate end-to-end Kubernetes cluster
type: application
version: 2.23.1
version: 2.23.2
sources:
- https://github.com/cloudentity/acp-helm-charts
dependencies:
Expand All @@ -19,6 +19,6 @@ dependencies:
repository: https://charts.timescale.com
condition: timescaledb-single.enabled
- name: acp
version: "2.23.1"
version: "2.23.2"
repository: https://charts.cloudentity.io
condition: acp.enabled
6 changes: 6 additions & 0 deletions charts/kube-acp-stack/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,12 @@ $ helm upgrade [RELEASE_NAME] acp/kube-acp-stack

_See [helm upgrade](https://helm.sh/docs/helm/helm_upgrade/) for command documentation._

### From 2.23.1 to 2.23.2

Version 2.23.2 of ACP kube stack helm chart uses `docker.secureauth.com` as the secret name referencing SecureAuth registry.
If you're using the `docker.cloudentity.io` and haven't overridden `imagePullSecrets` before, you have to create a new secret with the name `docker.secureauth.com`
See [Docker Pull Credentials](#docker-pull-credentials).

### From 2.x to 2.13.1

Default values for charts dependencies now set `fullnameOverride` to standarize database connection URLs. Users that want to keep old databases naming should set this values to `null`.
Expand Down
Loading