Validate a hash is legit when it links to its own page #2183
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this solve?
The validation script expects all the links to be both a path, then possibly a hash (eg
/docs/quickstart#login
) but sometimes a link only has a hash (eg#login
) pointing to another point on the page, so we need to validate those links. Currently the script just skips over those linksWhat changed?
Added tests with links that only use a hash, then fixed the script, to pull in its own doc to validate against.
Checklist