Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify dependencies & split CPU/GPU backend Dockerfiles #3

Merged
merged 36 commits into from
Feb 19, 2025

Conversation

LouisAsanaka
Copy link
Contributor

@LouisAsanaka LouisAsanaka commented Feb 15, 2025

  • Simplify dependencies into a single pyproject.toml file
  • Streamlined local build through Docker / direct setup using uv
  • Removed extra UniMERNet models to cut down image size (keeping the only base models)
  • Added frontend Dockerfile
  • Docker Compose is now working

@LouisAsanaka LouisAsanaka marked this pull request as draft February 15, 2025 07:58
@LouisAsanaka
Copy link
Contributor Author

LouisAsanaka commented Feb 15, 2025

TODO: Download model in the workflow step before Docker build

@LouisAsanaka LouisAsanaka marked this pull request as ready for review February 16, 2025 00:06
@deluzhao
Copy link
Contributor

deluzhao commented Feb 18, 2025

A bit concerned about removing Omniparser. The file structure that I'm using here is not default and a pure re-install of Omniparser won't restore the file structure. I committed Omniparser because the non-downloaded model files are relatively lightweight. Why is Omniparser being considered unused? Is this for demo purposes?

@LouisAsanaka
Copy link
Contributor Author

Is Omniparser still being used for the main pipeline? I think I mistook it being unused because it was commented out. I'll restore the directory.

Also, are only the weights of Omniparser used? We can move Omniparser code into the main source, and leave only model weights in models/

@deluzhao
Copy link
Contributor

I think the configs are also used and I wouldn't remove the license just in case. There's probably some unused files, but this is largely just a restructured directory from Omniparser, so I didn't really try to touch individual files. I can look at reducing the files as a secondary priority after we complete the big action items.

@LouisAsanaka
Copy link
Contributor Author

@deluzhao I've restored OmniParser and the relevant task.

@LouisAsanaka LouisAsanaka merged commit 632adb9 into main Feb 19, 2025
2 checks passed
@LouisAsanaka LouisAsanaka deleted the build-instructions branch February 19, 2025 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants