Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade to spring v6.2.0 #1270

Merged
merged 1 commit into from
Nov 28, 2024
Merged

upgrade to spring v6.2.0 #1270

merged 1 commit into from
Nov 28, 2024

Conversation

bbortt
Copy link
Collaborator

@bbortt bbortt commented Nov 26, 2024

No description provided.

@bbortt bbortt self-assigned this Nov 26, 2024
@bbortt bbortt added Prio: High Type: Dependencies Pull requests that update a dependency file labels Nov 26, 2024
@bbortt bbortt mentioned this pull request Nov 26, 2024
Merged
@bbortt bbortt force-pushed the main branch 2 times, most recently from dc0e001 to 2f5bae5 Compare November 27, 2024 14:32
@bbortt bbortt requested a review from christophd November 27, 2024 14:52
@bbortt
Copy link
Collaborator Author

bbortt commented Nov 27, 2024

@christophd upgrade to spring release v6.2.0. please note the small breaking changes.

christophd
christophd approved these changes Nov 28, 2024
View reviewed changes
Copy link
Member

@christophd christophd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, many thanks for the new unit tests. Would be good to add license headers to the new test classes though

@bbortt
feat(deps): upgrade to spring v6.2.0
478eebf 
this change is breaking, because Spring v6.2.0 is not compatible with releases prior to it. see
the [Spring Release Notes](https://github.com/spring-projects/spring-framework/wiki/Spring-Framework-6.2-Release-Notes)
for more information.
@bbortt
Copy link
Collaborator Author

bbortt commented Nov 28, 2024

Would be good to add license headers to the new test classes though

true, sorry I forgot that.

it is now done 😉

@bbortt bbortt merged commit 73c118b into citrusframework:main Nov 28, 2024
1 check passed
@vmeyer
Copy link

vmeyer commented Dec 10, 2024 •
edited
Loading

Hi,
we need this fix to be able to upgrade to spring-boot 3.4.0.

Our citrus-http-component tests with failure scenarios do not work anymore in combination with citrus-4.4.0 because of the changes in DefaultResponseErrorHandler. The propagation mode, which citrus overrides to be able to receive errors in http.client, is broken because of the changed method signature of "handleError" in spring 6.2.0.

When do you plan to release this upgrade?

Many thanks in advance
Volker

@bbortt bbortt deleted the main branch December 10, 2024 08:34
@bbortt
Copy link
Collaborator Author

bbortt commented Dec 10, 2024

When do you plan to release this upgrade?

@christophd has to do that. I think a feature-release would be appropriate. I do need it to to get citrusframework/citrus-simulator#316 working.

@christophd
Copy link
Member

Sure, I can cut a release this week

@christophd
Copy link
Member

@vmeyer @bbortt Citrus 4.5.0 is available. Please let me know if it works for you now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christophd christophd christophd approved these changes

Assignees

@bbortt bbortt

Labels
Prio: High Type: Dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bbortt @vmeyer @christophd