Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#281): fix delete test-result in backend #297

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

MeToCo
Copy link
Contributor

@MeToCo MeToCo commented Aug 20, 2024

Added a cascade all to TestResult and ScenarioExecution relation to propagate the delete of the TestReuslt to the ScenarioExecution

@bbortt
Copy link
Collaborator

bbortt commented Aug 20, 2024

did you test this while running the application? is there an existing integration test verifying the behavior?

@bbortt
Copy link
Collaborator

bbortt commented Aug 20, 2024

oh, and you should rebase your branch @MelvinJohner 😉

@bbortt bbortt force-pushed the main branch 3 times, most recently from e852eb6 to 1608eaa Compare August 22, 2024 06:38
@bbortt
Copy link
Collaborator

bbortt commented Aug 22, 2024

@MelvinJohner thanks for the fix. I've rebased and squashed it. I've also made sure that only the REMOVE-event get's cascaded. that is the least possible change to the previous version and should also do the trick.

@bbortt bbortt merged commit 15afe9c into citrusframework:main Aug 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants