simulator run modes: [async/sync] #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbortt
added
Type: Enhancement
IN PROGRESS
Prio: Medium
javascript
bbortt
force-pushed
the
feat/simulator-modes
branch
from
9b125b2 to
7da5a64
Compare
bbortt
added
java
|
@novarx interested in your opinion! |
novarx
reviewed
Feb 9, 2024
.../main/java/org/citrusframework/simulator/service/runner/SyncScenarioExecutorServiceImpl.java
Outdated
Show resolved
Hide resolved
yeah, didn't even know if this proves usable.. so, didn't bother. |
bbortt
force-pushed
the
feat/simulator-modes
branch
2 times, most recently
from
2403382 to
e1c40ea
Compare
bbortt
commented
Feb 13, 2024
...test/java/org/citrusframework/simulator/service/runner/DefaultScenarioExecutorServiceIT.java
Show resolved
Hide resolved
bbortt
requested review from
christophd and
novarx
and removed request for
novarx
bbortt
commented
Feb 14, 2024
...test/java/org/citrusframework/simulator/service/runner/DefaultScenarioExecutorServiceIT.java
Outdated
Show resolved
Hide resolved
...rc/test/java/org/citrusframework/simulator/service/runner/SyncScenarioExecutorServiceIT.java
Outdated
Show resolved
Hide resolved
...lator-spring-boot/src/main/java/org/citrusframework/simulator/web/rest/ScenarioResource.java
Show resolved
Hide resolved
tschlat
reviewed
Feb 15, 2024
...pring-boot/src/main/java/org/citrusframework/simulator/listener/SimulatorStatusListener.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/citrusframework/simulator/service/runner/AsyncScenarioExecutorService.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/citrusframework/simulator/service/runner/DefaultScenarioExecutorService.java
Show resolved
Hide resolved
bbortt
force-pushed
the
feat/simulator-modes
branch
from
e1c40ea to
940704a
Compare
|
@christophd are you ok with this change? 🥇 |
bbortt
force-pushed
the
feat/simulator-modes
branch
from
940704a to
0bbc987
Compare
note that we've beta tested this internally and fixed another two bugs in the process. I must sign this commits of tonight, before merging. |
Signed-off-by: Timon Borter <timon.borter@gmx.ch>
the property `citrus.simulator.mode=[async/sync]` steers the mode the simulator will use to execute simulations. note that while the synchronous modus is simpler, it disallows the simulation of any intermediate messaging with synchronous protocols. Signed-off-by: Timon Borter <timon.borter@gmx.ch>
Signed-off-by: Timon Borter <timon.borter@gmx.ch>
Signed-off-by: Timon Borter <timon.borter@gmx.ch>
Signed-off-by: Timon Borter <timon.borter@gmx.ch>
bbortt
force-pushed
the
feat/simulator-modes
branch
from
0bbc987 to
0c23ed5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add "run modes" to the simulator:
syncallows only request-response simulations, because there is no additional threadasyncallows intermediate messaging, if that is requried, uses an additional thread pool for simulations