Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename citrus simulator starter #193

Merged
merged 2 commits into from
Nov 20, 2023

Conversation

bbortt
Copy link
Collaborator

@bbortt bbortt commented Nov 2, 2023

citrus-simulator-starter module does no longer exist, it has been renamed to citrus-spring-boot-simulator, so that the dependency on spring-boot is mentioned more explicitly.

BREAKING CHANGE: renamed citrus-simulator-starter.

closes #181.

@@ -73,7 +73,7 @@ targetCompatibility = 17

dependencies {
implementation("org.springframework.boot:spring-boot-starter-web")
implementation("org.citrusframework:citrus-simulator-starter:1.2-SNAPSHOT")
implementation("org.citrusframework:citrus-spring-boot-simulator:3.0.0")
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@christophd it looks like this one is not updated by the release script.

@@ -42,12 +42,12 @@ targetCompatibility = 1.8

dependencies {
implementation("org.springframework.boot:spring-boot-starter-web")
implementation("org.citrusframework:citrus-simulator-starter:1.0.0")
implementation("org.citrusframework:citrus-spring-boot-simulator:3.0.0")
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neither is this.

@bbortt
Copy link
Collaborator Author

bbortt commented Nov 3, 2023

@christophd I think with this and #197 being merged we're ready for a first milestone release of the simulator. I'll follow up with documentation and fixed archetypes this weekend. I think I'll find time.

@bbortt bbortt force-pushed the feature/#181-rename-citrus-simulator-starter branch from 8b28870 to 515b77c Compare November 3, 2023 12:27
@bbortt bbortt mentioned this pull request Nov 5, 2023
3 tasks
Copy link
Member

@christophd christophd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I am happy to merge but we need to resolve the merge conflicts

module does no longer exist, it has been renamed to `citrus-spring-boot-simulator`,
so that the dependency on spring-boot is mentioned more explicitly.

BREAKING CHANGE: renamed `citrus-simulator-starter`.
@bbortt bbortt force-pushed the feature/#181-rename-citrus-simulator-starter branch from 515b77c to b38d7fe Compare November 20, 2023 18:48
@bbortt bbortt force-pushed the feature/#181-rename-citrus-simulator-starter branch from b38d7fe to 34852bf Compare November 20, 2023 18:50
@bbortt
Copy link
Collaborator Author

bbortt commented Nov 20, 2023

@christophd I've resolved all conflicts. for a release I'd suggest including #219 too.

@bbortt bbortt merged commit 191f759 into main Nov 20, 2023
6 checks passed
@bbortt bbortt deleted the feature/#181-rename-citrus-simulator-starter branch February 8, 2024 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

renaming simulator-starter
2 participants