-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rename citrus simulator starter #193
Conversation
@@ -73,7 +73,7 @@ targetCompatibility = 17 | |||
|
|||
dependencies { | |||
implementation("org.springframework.boot:spring-boot-starter-web") | |||
implementation("org.citrusframework:citrus-simulator-starter:1.2-SNAPSHOT") | |||
implementation("org.citrusframework:citrus-spring-boot-simulator:3.0.0") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@christophd it looks like this one is not updated by the release
script.
@@ -42,12 +42,12 @@ targetCompatibility = 1.8 | |||
|
|||
dependencies { | |||
implementation("org.springframework.boot:spring-boot-starter-web") | |||
implementation("org.citrusframework:citrus-simulator-starter:1.0.0") | |||
implementation("org.citrusframework:citrus-spring-boot-simulator:3.0.0") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
neither is this.
@christophd I think with this and #197 being merged we're ready for a first milestone release of the simulator. I'll follow up with documentation and fixed archetypes this weekend. I think I'll find time. |
8b28870
to
515b77c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I am happy to merge but we need to resolve the merge conflicts
module does no longer exist, it has been renamed to `citrus-spring-boot-simulator`, so that the dependency on spring-boot is mentioned more explicitly. BREAKING CHANGE: renamed `citrus-simulator-starter`.
515b77c
to
b38d7fe
Compare
b38d7fe
to
34852bf
Compare
@christophd I've resolved all conflicts. for a release I'd suggest including #219 too. |
citrus-simulator-starter
module does no longer exist, it has been renamed tocitrus-spring-boot-simulator
, so that the dependency on spring-boot is mentioned more explicitly.BREAKING CHANGE: renamed
citrus-simulator-starter
.closes #181.