feat: use image tag for app version #486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidsauntson
force-pushed
the
fix/app-version
branch
from
e01429a to
5292e59
Compare
davidsauntson
force-pushed
the
fix/app-version
branch
from
5292e59 to
af602ad
Compare
davidsauntson
force-pushed
the
fix/app-version
branch
from
af602ad to
a68b493
Compare
davidsauntson
force-pushed
the
fix/app-version
branch
from
a68b493 to
1ca0188
Compare
davidsauntson
force-pushed
the
fix/app-version
branch
from
1ca0188 to
d68b462
Compare
davidsauntson
force-pushed
the
fix/app-version
branch
from
d68b462 to
7c3a1a0
Compare
davidsauntson
force-pushed
the
fix/app-version
branch
from
7c3a1a0 to
d3410f7
Compare
davidsauntson
force-pushed
the
fix/app-version
branch
from
d3410f7 to
ab8752a
Compare
davidsauntson
force-pushed
the
fix/app-version
branch
from
ab8752a to
79a9f12
Compare
davidsauntson
force-pushed
the
fix/app-version
branch
from
79a9f12 to
b9f09bf
Compare
davidsauntson
commented
Feb 5, 2025
| @@ -51,6 +51,8 @@ spec: | |||
| image: "{{ .Values.image.repository }}:{{ .Values.image.tag | default .Chart.AppVersion }}" | |||
| imagePullPolicy: {{ .Values.image.pullPolicy }} | |||
| env: | |||
| - name: APP_VERSION | |||
| value: {{ .Values.image.tag }} | |||
There was a problem hiding this comment.
I'm unable to get the commit sha into the values.yaml or <stage>.yaml files. Neither the .Values.image.tag or the github.sha methods are available there. But I think it's fine here because it doesn't change per env anyway.
There was a problem hiding this comment.
out of interest, where is this env var used, is it for the app to knows its own version? I'm a bit confused about what this PR tries to achieve
There was a problem hiding this comment.
Sorry - I've updated the description. It follows on from this PR #483
cnorthwood
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows on from #483
Fixes the
APP_VERSIONenv var so that it is:deployment.yamlfileIMAGE_TAGused in the docker build and push step