Update warning screen natives #1041
Open
+177
−237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PsychoShock
suggested changes
Mar 27, 2024
|
Can you squash everything btw please? :) |
Update warning screen natives Update SetWarningMessageWithHeader Documented params and description Add button list to SetWarningMessage Update IsWarningMessageActive_2 Update SetWarningMessageWithHeaderAndSubstringFlags Fix oversight in SetWarningMessageWithHeaderAndSubstringFlags update native name in example SET_WARNING_MESSAGE_WITH_ALERT documented everything regarding this native Update GetWarningScreenMessageTitleHash.md added that this native returns 0 if warning message isnt active Remove dead imgur link in SetWarningMessage Update SetWarningMessage.md Removed gist link and improved information about buttons to help make it easier for people to understand
Did some testing and this doesn't seem to be case
AvarianKnight
requested changes
Aug 2, 2024
|
|
||
| **Result of the example code:** | ||
| [https://i.imgur.com/imwoimm.png](https://i.imgur.com/imwoimm.png) | ||
| | Button Index | Button Text | Button Input | Notes | |
There was a problem hiding this comment.
Please use an enum over a table.
AvarianKnight
added
the
needs validation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrected names and documented all the parameters