Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SetPedHeadBlendData.md #1024

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pauIbanez
Copy link

updated to clarify the crucial info the linked topic provides

Before you submit this PR, please make sure:

  • You have read the contribution guidelines
  • You include an example that validates your change
  • Your English is grammatically correct

updated to clarify the crucial info the linked topic provides
@PsychoShock
Copy link
Contributor

I'll join @4mmonium

Maybe the images would fit better perhaps in the game references section of the docs.

Copy link
Contributor

@4mmonium 4mmonium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be better to not link off-site, mainly due to availability purposes.

@@ -8,11 +8,11 @@ ns: PED
void SET_PED_HEAD_BLEND_DATA(Ped ped, int shapeFirstID, int shapeSecondID, int shapeThirdID, int skinFirstID, int skinSecondID, int skinThirdID, float shapeMix, float skinMix, float thirdMix, BOOL isParent);
```

For more info please refer to [this](https://gtaforums.com/topic/858970-all-gtao-face-ids-pedset-ped-head-blend-data-explained) topic.
For more info and the list of faceIDs please refer to [this](https://gtaforums.com/topic/858970-all-gtao-face-ids-pedset-ped-head-blend-data-explained) topic. Note that the Skin and Shape IDs are shared. This native will use this same list for both Skin and Shape IDs.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As @PsychoShock said, it would be better to have these things (such as images and others) in the game references section, rather than linking off-site. What if these resources go down?

Copy link
Contributor

@PsychoShock PsychoShock Feb 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you prefer adding a new page on docs or just doing a special "peds" folder on game-references and adding everything related to them in the future @4mmonium (that would break fivem-peds link page tho (if we moving it) but would make more sense for futur updates on peds.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! I agree that this info should be somewhere within the docs, let me know abou your decision and any changes you want me to make!

I could also help setting up the page/section for this info.

@AvarianKnight AvarianKnight added needs validation This looks good, but needs additional confirmation of suggested change. merging-blocked PR is waiting for something else to be merged. and removed needs validation This looks good, but needs additional confirmation of suggested change. labels Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merging-blocked PR is waiting for something else to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants