e2e tests minor patches #2225
Merged
e2e tests minor patches #2225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... and a variable for only running specific tests. Signed-off-by: Kornilios Kourtis <kornilios@isovalent.com>
For some e2e tests, we install cilium. While everyone appreciates vintage cilium versions, let's run a more recent one which is actually supported. Signed-off-by: Kornilios Kourtis <kornilios@isovalent.com>
lambdanis
reviewed
Mar 15, 2024
Comment on lines
+125
to
+128
| @echo 'End-to-end tests: ' | ||
| @echo ' e2e-test - run e2e tests' | ||
| @echo ' e2e-test E2E_BUILD_IMAGES=0 - run e2e tests without (re-)building images' | ||
| @echo ' e2e-test E2E_TESTS=./tests/e2e/tests/skeleton - run a specific e2e test' |
There was a problem hiding this comment.
I was just thinking we should do something like https://www.thapaliya.com/en/writings/well-documented-makefiles/, because many targets are missing from this help. But I'm not sure how to best document multiple options for one target then. (I mean, it's very helpful to have options documented, I'm just thinking out loud here)
There was a problem hiding this comment.
I guess we could something like
e2e-tests: ## run e2e tests, use E2E_BUILD_IMAGES=0 to avoid running images and E2E_TESTS=./tests/e2e/tests/skeleton ro run only the skeleton test
lambdanis
reviewed
Mar 15, 2024
| @@ -26,7 +26,7 @@ var Opts = Flags{ | |||
| }, | |||
| KeepExportData: false, | |||
| InstallCilium: true, | |||
| CiliumVersion: "v1.12.6", | |||
| CiliumVersion: "v1.15.1", | |||
There was a problem hiding this comment.
#renovateit We can at least add a note to Renovate's draft PRs to make sure it's updated I guess?
mtardy
added
the
release-note/misc
mtardy
approved these changes
Mar 15, 2024
5 tasks
|
Thanks! @lambdanis I think your comments make sense, but I'll merge this since I think it's an improvement and we can follow up with additional enhancements. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.