docs: fix typos, fix k8s install guide for zsh and update Cilium SW demo #1965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Declare `demo_app_url` as a parameter in hugo.toml so that its value becomes available in Hugo shortcodes [1]. In turn, this allows us to format markdown templates. See commit cca7655 that previously modified Hugo's configuration file. Also fix some typos and perform nits. [1] https://gohugo.io/content-management/shortcodes/#param Signed-off-by: Ioannis Androulidakis <androulidakis.ioannis@gmail.com>
When running the K8s installation guide with zsh the following commands:
EXTRA_HELM_FLAGS="--set tetragon.hostProcPath=/procHost"
helm install tetragon ${EXTRA_HELM_FLAGS} cilium/tetragon -n kube-system
fail with:
Error: unknown flag: --set tetragon.hostProcPath
The reason for this is that zsh does not split into words when it
expands parameters by default [2]. For example, in a zsh shell:
EXTRA_FLAGS="--namespace kube-system"; strace -e trace=execve kubectl get pods ${EXTRA_FLAGS} 2>&1 | grep -m1 kubectl
execve("/usr/bin/kubectl", ["kubectl", "get", "pods", "--namespace kube-system"], 0x7ffe5a984d38 /* 63 vars */) = 0
Fix this by using arrays to pass extra Helm flags which works in both
bash and zsh shells.
[1] https://linux.die.net/man/1/zshexpn
Signed-off-by: Ioannis Androulidakis <androulidakis.ioannis@gmail.com>
✅ Deploy Preview for tetragon ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mtardy
requested changes
Jan 12, 2024
mtardy
added
area/documentation
mtardy
changed the title
mtardy
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides the following fixes for Tetragon's docs:
kubectlcommandszshandbashshellsSigned-off-by: Ioannis Androulidakis androulidakis.ioannis@gmail.com