Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve local k8s developer experience #1920

Merged
merged 1 commit into from
Jan 5, 2024
Merged

Improve local k8s developer experience #1920

merged 1 commit into from
Jan 5, 2024

Conversation

sadath-12
Copy link
Contributor

@sadath-12 sadath-12 commented Dec 28, 2023 •
edited
Loading

Compile all commands listed for kind setup into one make command via make kind-setup and updated docs accordingly and removes minikube setup as there is neglible chances that someone will use it over kind and we have to make our docs clean

Closes #1849

@sadath-12 sadath-12 requested review from mtardy and a team as code owners December 28, 2023 12:35
@netlify Netlify
Copy link

netlify bot commented Dec 28, 2023 •
edited
Loading

✅ Deploy Preview for tetragon ready!

Name Link
🔨 Latest commit 9d65459
🔍 Latest deploy log https://app.netlify.com/sites/tetragon/deploys/6596de5e7e1bae00081257e0
😎 Deploy Preview https://deploy-preview-1920--tetragon.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@lambdanis lambdanis added the release-note/misc This PR makes changes that have no direct user impact. label Jan 3, 2024
lambdanis
lambdanis reviewed Jan 3, 2024
View reviewed changes
Copy link
Contributor

@lambdanis lambdanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @sadath-12, I left some comments regarding rules names mostly.

Please also squash the commits for clean git history :)

@lambdanis lambdanis self-assigned this Jan 3, 2024
@sadath-12
Copy link
Contributor Author

Thank you @lambdanis for helping this improve

@sadath-12 sadath-12 mentioned this pull request Jan 4, 2024
Draft
lambdanis
lambdanis approved these changes Jan 4, 2024
View reviewed changes
Copy link
Contributor

@lambdanis lambdanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, thanks!

mtardy
mtardy requested changes Jan 4, 2024
View reviewed changes
Copy link
Member

@mtardy mtardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks look good, I'm sorry I would just block this as it will change the default make target. See comments.

@mtardy
Copy link
Member

mtardy commented Jan 4, 2024

This is also a nit but checkpatch is detecting you have duplicate signature in your commit message. You can use git commit --amend to remove the unnecessary line. The commit should look like this (with empty lines):

<subsystem>: <title>

<body>

<signature>

@sadath-12
Copy link
Contributor Author

updated . thank you @mtardy

@mtardy mtardy self-requested a review January 4, 2024 18:49
mtardy
mtardy approved these changes Jan 4, 2024
View reviewed changes
Copy link
Member

@mtardy mtardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was mostly commenting on the Makefile changes, if @lambdanis approves this I'm okay! :) Thanks for the work!

@sadath-12
chore: Improve local k8s developer experience
7b6254a 
Compile all commands listed for kind setup into one make command via make kind-setup and updated docs accordingly along removing minikube setup

Signed-off-by: sadath-12 <sadathsadu2002@gmail.com>
@lambdanis lambdanis merged commit 56edf16 into cilium:main Jan 5, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lambdanis lambdanis lambdanis approved these changes

@mtardy mtardy mtardy approved these changes

Assignees

@lambdanis lambdanis

Labels
release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve local k8s developer experience
3 participants
@sadath-12 @mtardy @lambdanis