Skip to content

Commit

Permalink
ci/generated_files: change ref to ref_name
Browse files Browse the repository at this point in the history
Use `${{ github.ref_name }}` instead of `${{ github.ref }}` to hopefully finally fix an
issue with the branch name passed to buf.

Signed-off-by: William Findlay <william.findlay@isovalent.com>
  • Loading branch information
will-isovalent committed Feb 18, 2025
1 parent 0e56d5d commit 3590a67
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/generated-files.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
# TODO: enable linting once we have a chance to fix the underlying issues
# make -C api lint EXTRA_BUF_FLAGS="--error-format=github-actions"
if ${{ github.event_name == 'push' }}; then
make -C api check-breaking EXTRA_BUF_FLAGS="--error-format=github-actions" BUF_BREAKING_AGAINST_BRANCH="origin/${{ github.ref }}"
make -C api check-breaking EXTRA_BUF_FLAGS="--error-format=github-actions" BUF_BREAKING_AGAINST_BRANCH="origin/${{ github.ref_name }}"
else
make -C api check-breaking EXTRA_BUF_FLAGS="--error-format=github-actions" BUF_BREAKING_AGAINST_BRANCH="origin/${{ github.base_ref }}"
fi
Expand All @@ -44,7 +44,7 @@ jobs:
run: |
make generate
if ${{ github.event_name == 'push' }}; then
make codegen BUF_BREAKING_AGAINST_BRANCH="origin/${{ github.ref }}"
make codegen BUF_BREAKING_AGAINST_BRANCH="origin/${{ github.ref_name }}"
else
make codegen BUF_BREAKING_AGAINST_BRANCH="origin/${{ github.base_ref }}"
fi
Expand Down

0 comments on commit 3590a67

Please sign in to comment.