-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add LoongArch support #337
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Do you also want to generate loongarch binary on release? (then you can download pre-compiled pwru from https://github.com/cilium/pwru/releases/) If so, some minor changes on Makefile (local-release
) shall be made.
@chenhengqi 👋 Bump |
Update libbpf to its latest release, which contains support for LoongArch. Signed-off-by: Hengqi Chen <hengqi.chen@gmail.com>
The vmlinux.h is generated on Linux v6.7. This enables building kprobe_pwru on LoongArch. Signed-off-by: Hengqi Chen <hengqi.chen@gmail.com>
With this change, we can now build pwru on LoongArch using: $ make TARGET_GOARCH=loong64 GOARCH=loong64 LIBPCAP_ARCH= Signed-off-by: Hengqi Chen <hengqi.chen@gmail.com>
Sorry for the long delay. I am inclined to keep it as it is for now. Thanks. |
@brb Just rebase and mark it as ready for review. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes LGTM, my only concern is neither I or CI don't have Loong env to test it. @chenhengqi Have you run the pwru compiled from this PR?
Yep, I run it on my 3A5000 machine. |
@chenhengqi Thanks for the PR. Would you mind providing a GH runner to that we can test pwru on it? Happy to help with setup. |
OK, just add to my TODO list. |
No description provided.