Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove -Xbootlasspath/a option of the cljam executable #296

Closed
wants to merge 1 commit into from

Conversation

alumi
Copy link
Member

@alumi alumi commented Dec 12, 2023

Fixes #295

This PR removes -Xbootclasspath/a option from the header of the cljam executable built by lein bin to avoid a NPE from commons-compress >= 1.21.
The default value of :bootclasspath in lein-binplus is false.

@alumi alumi added the bug label Dec 12, 2023
@alumi alumi requested a review from a team as a code owner December 12, 2023 13:42
@alumi alumi requested review from athos and r6eve and removed request for a team December 12, 2023 13:42
Copy link

codecov bot commented Dec 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8cf394e) 88.31% compared to head (7e65858) 88.31%.
Report is 11 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #296      +/-   ##
==========================================
- Coverage   88.31%   88.31%   -0.01%     
==========================================
  Files          81       83       +2     
  Lines        7058     7306     +248     
  Branches      488      492       +4     
==========================================
+ Hits         6233     6452     +219     
- Misses        337      366      +29     
  Partials      488      488              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alumi
Copy link
Member Author

alumi commented Dec 13, 2023

The issue will be solved by upgrading commons-compress to >= 1.25.1

@alumi alumi closed this Dec 13, 2023
@alumi alumi deleted the fix/bootclasspath branch May 13, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dict command after cljam 0.8.2 fails
1 participant