improve secure-join message detection #473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI is failing because of unrelated file formatting, should be fixed by merging #474 first Would be nice to have at least one test for this fix. Changelog is managed manually in this repo, so PR needs a changelog entry. |
link2xt
reviewed
Jan 24, 2025
| return False | ||
| parts_count = 0 | ||
| for part in message.iter_parts(): | ||
| if parts_count == 0: |
There was a problem hiding this comment.
Could be flattened to if parts_count > 0: return False, but otherwise the function looks good.
There was a problem hiding this comment.
improved the code to be easier to understand that what we are rejecting is when message has parts_count > 1
adbenitez
force-pushed
the
adb/patch-secure-join-detection
branch
from
03039be to
b2eaf1a
Compare
|
This needs rebase now that CI on the main is fixed. |
link2xt
force-pushed
the
adb/patch-secure-join-detection
branch
from
b6d49d2 to
704e464
Compare
|
Rebased it now |
link2xt
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
be more strict in checking the secure-join special message structure
still missing: arbitrary Subject header is still allowed