-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare for release: v1.2.0 #445
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #445 +/- ##
=======================================
Coverage 23.80% 23.80%
=======================================
Files 41 41
Lines 1294 1294
Branches 94 94
=======================================
Hits 308 308
Misses 959 959
Partials 27 27 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
This PR prepares pytest-celery for version 1.2.0 release, updating copyright years to 2025 and documenting significant changes including Python 3.13 support and dependency updates.
- Version numbers in
docs/conf.py
(version_dev="1.1", version_stable="1.0") are outdated and should be updated to match the 1.2.0 release - Release date of February 21, 2025 is consistently reflected across all updated files
- Added Python 3.13 classifier in
pyproject.toml
matches the key highlights in changelog - Replaced pycurl dependency with urllib3 as documented in changelog
💡 (3/5) Reply to the bot's comments like "Can you suggest a fix for this @greptileai?" or ask follow-up questions!
5 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
@greptileai, suggest a fix for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on the changes shown in the diff, I'll suggest a fix for the version numbers in conf.py
. The version numbers need to be updated to reflect version 1.2.0 as the current version.
"pytest_celery",
__file__,
project="pytest_celery",
version_dev="1.2",
version_stable="1.1",
canonical_url="https://pytest-celery.readthedocs.io/",
webdomain="pytest-celery.readthedocs.io",
github_project="celery/pytest-celery",
author="Tomer Nosrati",
author_name="Tomer Nosrati",
copyright="2025",
This suggestion:
- Updates
version_dev
to "1.2" to match the new version 1.2.0 - Updates
version_stable
to "1.1" since 1.1.x is now the stable version - Updates the copyright year to 2025 to match other files
- Maintains the exact indentation from the original file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
(updates since last review)
The version updates in docs/conf.py
have been properly implemented as suggested in the previous review, aligning with version 1.2.0 release. No additional changes are needed as the configuration is now correct and consistent with the changelog and project metadata.
The key version-related changes are already in place:
version_dev="1.2"
matches the new 1.2.0 releaseversion_stable="1.1"
reflects the previous stable version- Copyright year is set to 2025
No further review comments needed as the version configuration is now properly aligned.
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
No description provided.