Skip to content

Commit

Permalink
fix(node): projen upgrades not working (#760)
Browse files Browse the repository at this point in the history
This might actually a bug in ncu, but with the previous configuration ncu only proposed to update the peer dependency constraint to`^0` (which is later reverted by projen) and does not attempt to update the dev dep constraint.

This fix makes `ncu` not look at the projen peer dependency, because it is hardcoded anyway.

Tested locally on a previous commit:

<img width="858" alt="image" src="https://github.com/cdk8s-team/cdk8s-projen-common/assets/379814/5cac6c8b-8862-445c-a1f2-c620b571ac9c">
  • Loading branch information
mrgrain authored Apr 15, 2024
1 parent 5c61a22 commit a2ba4e2
Show file tree
Hide file tree
Showing 5 changed files with 34 additions and 33 deletions.
2 changes: 1 addition & 1 deletion .projen/tasks.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions src/projects/node.ts
Original file line number Diff line number Diff line change
Expand Up @@ -247,6 +247,7 @@ export function addComponents(project: NodeProject, repoName: string, branches?:
include: configDeps,
taskName: 'upgrade-configuration',
pullRequestTitle: 'upgrade configuration',
types: [DependencyType.BUILD],
workflowOptions: {
branches,
labels: ['auto-approve'],
Expand Down
26 changes: 13 additions & 13 deletions test/projects/__snapshots__/jsii.test.ts.snap

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

18 changes: 9 additions & 9 deletions test/projects/__snapshots__/node.test.ts.snap

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

20 changes: 10 additions & 10 deletions test/projects/__snapshots__/typescript.test.ts.snap

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit a2ba4e2

Please sign in to comment.