Feature visibility #221
Merged
Feature visibility #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll merge this (possibly partial) fix now since we're getting ready for a release. I'll be more than happy to reopen for the cygwin and win32 branches in sc.h. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add visibility attribute for GCC >= 4
Proposed changes
Using p4est from a certain python library turned up multiple instances of the same extern variable, namely the package id (used internally for registering log priorities and debug memory counters). Add some defines to use the visibility attribute.
The attribute is placed only in the .h file for now. To make it work on windows, we may have to add it in front of the definition in the .c file, which I find a bit annoying. Shall we do it anyway or is the current approach sufficient?
Curious on feedback. @tamiko @sloede @lukasdreyer