-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Treat null
value as any type when generating schema from Helm chart
#1677
Treat null
value as any type when generating schema from Helm chart
#1677
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nobody asked me, but I love it!
2e22d0d
to
668024c
Compare
null
in Helm value as _any_null
value as any type when generating schema from Helm chart
whoops. failing e2e tests. i'm on it ... |
668024c
to
d64e8fe
Compare
fixes carvel-dev#1630 Signed-off-by: Max Brauer <mbrauer@vmware.com>
d64e8fe
to
49bb275
Compare
green! ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the PR! Looks good 🚀
refs carvel-dev/kapp-controller#1677 Signed-off-by: Max Brauer <mbrauer@vmware.com>
refs carvel-dev/kapp-controller#1677 Signed-off-by: Max Brauer <mbrauer@vmware.com>
What this PR does / why we need it:
This change treats
null
values in Helm chart values as any type using a type union of all possible types being nullable. That is because the expected type cannot be inferred fromnull
.When releasing a
Package
from a Helm chart that hasnull
values, the result looks like this:as opposed to the previous:
Which issue(s) this PR fixes:
Fixes #1630
Does this PR introduce a user-facing change?
Additional Notes for your reviewer:
Review Checklist:
a link to that PR
change
Additional documentation e.g., Proposal, usage docs, etc.: