No processing of transactions during a decommit #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
ch1bo
requested changes
Aug 7, 2024
| @@ -84,8 +84,16 @@ | |||
| \On{$(\hpRS,v,s,\mT_{\mathsf{req}}, \tx_{\omega})$ from $\party_j$}{ | |||
| \Req{$v = \hatv ~ \land ~ s = \hats + 1 ~ \land ~ \hpLdr(s) = j$} \; | |||
| \Wait{$\hats = \bar{\mc S}.s$}{ | |||
| \Req{$\bar{\mc S}.U \applytx \tx_{\omega} \not= \bot$} \; | |||
| $U_{\mathsf{active}} \gets \bar{\mc S}.U \applytx \tx_{\omega} \setminus \mathsf{outputs(\tx_{\omega})}$ \; | |||
| \If{$v = \bar{\mc S}.v ~ \land ~ \bar{\mc S}.\tx_{\omega} \neq \bot$ }{ | |||
There was a problem hiding this comment.
Must: port this correctly!
This was the latest version of this section on the branch we worked together:
\Req{$s = \hats + 1 ~ \land ~ \hpLdr(s) = j$} \;
\Wait{$ v = \hatv ~ \land ~ \hats = \bar{\mc S}.s$}{
% TODO: waiting for version observed is way longer than for no snapshot in flight!
\If{$v = \bar{\mc S}.v ~ \land ~ \bar{\mc S}.\tx_{\omega} \neq \bot$ }{
\Req{$\bar{\mc S}.\tx_{\omega} = \tx_{\omega}$} \;
$U_{\mathsf{active}} \gets \bar{\mc S}.U$ \;
$U_{\omega} \gets \bar{\mc S}.U_{\omega}$
}
\Else{
\Req{$\bar{\mc S}.U \applytx \tx_{\omega} \not= \bot$} \;
$U_{\mathsf{active}} \gets \bar{\mc S}.U \applytx \tx_{\omega} \setminus \mathsf{outputs(\tx_{\omega})}$ \;
$U_{\omega} \gets \mathsf{outputs}(\tx_{\omega})$
There was a problem hiding this comment.
you mean I forgot the wait on version?
Signed-off-by: Sasha Bogicevic <sasha.bogicevic@iohk.io>
v0d1ch
force-pushed
the
spec-no-processing-of-transactions-during-decommit
branch
from
17adf1c to
fa26ee4
Compare
ch1bo
approved these changes
Aug 7, 2024
ch1bo
added a commit
to cardano-scaling/hydra
that referenced
this pull request
Aug 8, 2024
fix #1526 Related specification PR cardano-scaling/hydra-formal-specification#7 ### Why? - New L2 transactions fail when decommit is _in flight_ because we try to re-apply the local decommit tx ### What - Make sure the new snapshots are created only if the version is matched - Any pending decommit needs to match with the decommit in confirmed snapshot thus preserved in the next snapshot/s until it is observed. --- * [x] CHANGELOG updated or not needed * [x] Documentation updated or not needed * [x] Haddocks updated or not needed * [ ] No new TODOs introduced or explained herafter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ports the spec changes introduced in cardano-scaling/hydra#1540