Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Geoff Romer <gromer@google.com>
  • Loading branch information
chandlerc and geoffromer authored Mar 3, 2025
1 parent 47034e1 commit cf2ef10
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
5 changes: 4 additions & 1 deletion toolchain/base/llvm_tools.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,10 @@ _DEF_FILE_TEMPLATE = """
// Exceptions. See /LICENSE for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
// This is a generated X-macro header for defining LLVM tools.
// This is a generated X-macro header for defining LLVM tools. It does not use
// `#include` guards, and instead is designed to be `#include`ed after the
// x-macro is defined in order for its inclusion to expand to the desired
// output. Macro definitions are cleaned up at the end of this file.
//
// Each X-macro takes four arguments:
// - `Id` is the identifier-shaped PascalCased tool name.
Expand Down
2 changes: 1 addition & 1 deletion toolchain/driver/llvm_subcommand.h
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ struct LLVMOptions {
// Build the LLVM subcommand options using `b`.
//
// When this top-level subcommand is selected (potentially through a nested
// sub-subcommand), the `selected_subcommand` should be set to point to
// sub-subcommand), the `selected_subcommand` will be set to point to
// `subcommand` to reflect that.
auto Build(CommandLine::CommandBuilder& b, DriverSubcommand* subcommand,
DriverSubcommand** selected_subcommand) -> void;
Expand Down

0 comments on commit cf2ef10

Please sign in to comment.