Add authentication to CLI when submitting jobs with priority #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
val500
force-pushed
the
CERTTF-370-Create-new-endpoint-in-Testflinger-Server-to-authenticate-clients-and-distribute-tokens-for-submitting-jobs-with-priority
branch
from
442a39b to
6aee42d
Compare
val500
force-pushed
the
CERTTF-372-Update-Testflinger-CLI-to-authenticate-jobs-with-priority-with-the-server
branch
from
8bf4431 to
7fd149f
Compare
val500
force-pushed
the
CERTTF-370-Create-new-endpoint-in-Testflinger-Server-to-authenticate-clients-and-distribute-tokens-for-submitting-jobs-with-priority
branch
2 times, most recently
from
b2c6537 to
98ea5c0
Compare
val500
force-pushed
the
CERTTF-372-Update-Testflinger-CLI-to-authenticate-jobs-with-priority-with-the-server
branch
from
7fd149f to
6607d5a
Compare
val500
changed the base branch from
CERTTF-370-Create-new-endpoint-in-Testflinger-Server-to-authenticate-clients-and-distribute-tokens-for-submitting-jobs-with-priority
to
CERTTF-371
val500
force-pushed
the
CERTTF-372-Update-Testflinger-CLI-to-authenticate-jobs-with-priority-with-the-server
branch
from
6607d5a to
4cbe5e4
Compare
val500
force-pushed
the
CERTTF-371
branch
2 times, most recently
from
6719eb5 to
aca7c23
Compare
val500
force-pushed
the
CERTTF-372-Update-Testflinger-CLI-to-authenticate-jobs-with-priority-with-the-server
branch
from
4cbe5e4 to
5133174
Compare
val500
force-pushed
the
CERTTF-372-Update-Testflinger-CLI-to-authenticate-jobs-with-priority-with-the-server
branch
3 times, most recently
from
d27c81d to
47630d1
Compare
val500
force-pushed
the
CERTTF-372-Update-Testflinger-CLI-to-authenticate-jobs-with-priority-with-the-server
branch
from
626b2ee to
3df30ea
Compare
plars
suggested changes
Oct 28, 2024
Just added 2 unit tests - is there any other functionality you think it would be beneficial to test? |
plars
suggested changes
Oct 29, 2024
val500
force-pushed
the
CERTTF-372-Update-Testflinger-CLI-to-authenticate-jobs-with-priority-with-the-server
branch
from
69c322e to
ae353c2
Compare
plars
suggested changes
Oct 31, 2024
plars
deleted the
CERTTF-372-Update-Testflinger-CLI-to-authenticate-jobs-with-priority-with-the-server
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Requires #335 and #361. This updates the submit command in the Testflinger CLI to authenticate clients and authorize jobs that specify a job_priority in the yaml. For these jobs, the CLI will first get a token from the server, which requires a client_id and client-key. These can be specified as an environment variable, in the command line options, or in the config. The CLI will submit this token with the job.
Resolved issues
Resolves https://warthogs.atlassian.net/browse/CERTTF-372
Documentation
Documentation was added to the CLI README and submit-job documentation in docs/
Web service API changes
N/A
Tests
Unit tests were added to test_cli.py. These tests test that the JWT received from the authentication endpoint is passed with the job for jobs with priority, and jobs with priority are rejected when client credentials aren't specified in the CLI.