Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Riverside: Workaround PDU issue LP#2039983 #160

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

rmartin013
Copy link
Contributor

@rmartin013 rmartin013 commented Nov 10, 2023

Description

For Riverside, Jetson AGX, we experienced a weird issue while performing cold reboot with PDU (as part of the TF provisioning phase), with GRUB stopping its countdown counter and waiting while displaying its GRUB menu. This PR should workaround that issue by disabling the countdown counter and directly launching linux from GRUB.

Resolved issues

This PR fixes issue https://bugs.launchpad.net/bugs/2039983

Documentation

Tests

I have tested the commands used to change the GRUB configuration, but not using snappy-device-agent

@plars plars requested a review from a team November 10, 2023 10:13
Copy link
Contributor

@plars plars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests seem to just be failing due to the PR not being signed. Can you take a look at https://github.com/canonical/testflinger/blob/main/CONTRIBUTING.md and set up signing keys? Then there are some commands in that document which show you how to go back and sign your commits without having to start over completely

@rmartin013
Copy link
Contributor Author

@plars I pushed again my change, making sure my commit is signed, but still I get an error. I guess this is something else now...

@plars
Copy link
Contributor

plars commented Nov 14, 2023

/canonical/self-hosted-runners/run-workflows dcbe913

@plars
Copy link
Contributor

plars commented Nov 14, 2023

/canonical/self-hosted-runners/run-workflows a99048f

Copy link
Contributor

@plars plars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 thanks!

@plars plars merged commit 5093a85 into canonical:main Nov 14, 2023
2 checks passed
@rmartin013 rmartin013 deleted the riverside branch November 14, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants