Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix top navigation alignment #5000

Merged
merged 5 commits into from
Jan 29, 2025
Merged

Fix top navigation alignment #5000

merged 5 commits into from
Jan 29, 2025

Conversation

bartaz
Copy link
Member

@bartaz bartaz commented Jan 28, 2025

Done

Fixes the alignment of top navigation:

  • uses navigation 25/75 split from Vanilla
  • updates Vanilla (to fix the navigation wrapping issue)
  • removes unnecessary navigation customisations that were causing conflicts between Vanilla, global-nav and local responsive breakpoints

How to QA

  • visit home page on demo (https://snapcraft-io-5000.demos.haus/)
  • make sure top navigation is well aligned (first item should align with hero content)
  • make sure navigation works as expected on all screen sizes
  • repeat steps above for documentation (test locally as it's not available on demos)

Testing

  • This PR has tests
  • No testing required (explain why): visual changes only

Issue / Card

Fixes WD-18308

Screenshots

Before
image

After
image

@webteam-app
Copy link

@bartaz bartaz changed the title WIP: Nav fix Fix top navigation alignment Jan 28, 2025
@bartaz bartaz marked this pull request as ready for review January 29, 2025 08:21
@bartaz bartaz merged commit 48b62a8 into main Jan 29, 2025
11 checks passed
@bartaz bartaz deleted the nav-fix branch January 29, 2025 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants