Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for zeebe:LinkedResource #68

Merged
merged 3 commits into from
Jan 15, 2025
Merged

feat: add support for zeebe:LinkedResource #68

merged 3 commits into from
Jan 15, 2025

Conversation

marstamm
Copy link
Member

This allows modeling of zeebe:LinkedResource elements.

Related to bpmn-io/bpmn-js-element-templates#137

@marstamm marstamm requested a review from a team January 10, 2025 11:01
@marstamm marstamm self-assigned this Jan 10, 2025
@marstamm marstamm requested review from jarekdanielak and abdul99ahad and removed request for a team January 10, 2025 11:01
@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Jan 10, 2025
@marstamm marstamm mentioned this pull request Jan 13, 2025
Closed
6 tasks
@philippfromme philippfromme self-requested a review January 13, 2025 14:35
@philippfromme
Copy link
Contributor

Since you removed the duplicate property, is it correct, that this extension element will only be allowed for service tasks?

@marstamm
Copy link
Member Author

My understanding is that this is used for ServiceTasks only. I'll check with the Zeebe team to make sure

@marstamm
Copy link
Member Author

I confirmed: it will only be available on ServiceTasks: camunda/camunda#24774 (comment)

philippfromme
philippfromme reviewed Jan 14, 2025
View reviewed changes
test/spec/xml/read.js
@@ -317,6 +317,59 @@ describe('read', function() {
});


describe('zeebe:linkedResource', function() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No tests for write or roundtrip?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈

Added in 7056529

@philippfromme philippfromme self-requested a review January 15, 2025 10:28
philippfromme
philippfromme approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@philippfromme philippfromme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

jarekdanielak
jarekdanielak approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@jarekdanielak jarekdanielak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@marstamm marstamm merged commit 35b031f into main Jan 15, 2025
3 checks passed
@marstamm marstamm deleted the LinkedResource branch January 15, 2025 12:28
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Jan 15, 2025
@marstamm
Copy link
Member Author

Am I good to cut a release for this?

@philippfromme
Copy link
Contributor

Am I good to cut a release for this?

I don't know, are you?

@marstamm
Copy link
Member Author

I don't know, are you?

Looks like I can https://github.com/camunda/zeebe-bpmn-moddle/releases/tag/v1.8.0

@marstamm
Copy link
Member Author

never mind, I can not publish. Don't know why np went through with the push, but since I was removed from the bpmn-io group, I am not allowed to publish to npm and the release is not available there: https://www.npmjs.com/package/zeebe-bpmn-moddle/v/0.7.1?activeTab=versions

@marstamm
Copy link
Member Author

Can you please publish to npm?

@barmac
Copy link
Collaborator

barmac commented Jan 16, 2025

Will do

@barmac
Copy link
Collaborator

barmac commented Jan 16, 2025

OK it's now published.

@marstamm
Copy link
Member Author

Great, thank you! And sorry for pushing to your main branch, old habits 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philippfromme philippfromme philippfromme approved these changes

@jarekdanielak jarekdanielak jarekdanielak approved these changes

@abdul99ahad abdul99ahad Awaiting requested review from abdul99ahad abdul99ahad was automatically assigned from camunda/modeling-dev

Assignees

@marstamm marstamm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marstamm @philippfromme @barmac @jarekdanielak