Skip to content

Commit

Permalink
fix: use camunda/camunda repo for operate and zeebe (#684)
Browse files Browse the repository at this point in the history
* fix: use camunda/camunda repo for operate

* test: updates release-notes-fetcher test to use a more recent release

* fix: reference camunda/camunda in release asset downloader

* fix: wrong reference to camunda/camunda when explicit check for minor version is false
  • Loading branch information
jessesimpson36 authored Jun 10, 2024
1 parent d28bfee commit 25b1406
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 8 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/release-generation.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ jobs:
working-directory: ./release-notes-fetcher/tmp
run: |
gh release download "${ZEEBE_GITREF}" \
-R camunda/zeebe \
-R camunda/camunda \
-p "zbctl" \
-p "zbctl.sha1sum" \
-p "zbctl.exe" \
Expand All @@ -102,7 +102,7 @@ jobs:
working-directory: ./release-notes-fetcher/tmp
run: |
gh release download "operate-${OPERATE_GITREF}" \
-R camunda/zeebe \
-R camunda/camunda \
-p "camunda-operate-${OPERATE_GITREF}.zip" \
-p "camunda-operate-${OPERATE_GITREF}.zip.sha1sum" \
-p "camunda-operate-${OPERATE_GITREF}.tar.gz" \
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ jobs:
run: >
gh release
download "$GITHUB_REF_NAME"
-R camunda/zeebe
-R camunda/camunda
-p "zbctl"
-p "zbctl.sha1sum"
-p "zbctl.exe"
Expand All @@ -82,7 +82,7 @@ jobs:
run: >
gh release
download "operate-$GITHUB_REF_NAME"
-R camunda/zeebe
-R camunda/camunda
-p "camunda-operate-$GITHUB_REF_NAME.zip"
-p "camunda-operate-$GITHUB_REF_NAME.zip.sha1sum"
-p "camunda-operate-$GITHUB_REF_NAME.tar.gz"
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test-release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ jobs:
working-directory: ./release-notes-fetcher
# The var CAMUNDA_RELEASE_NAME should be the same as GITHUB_REF_NAME but it's hard-coded as 8.3.1 tag
# and we just want to see if a valid version can fetch notes
run: set -o pipefail; CAMUNDA_RELEASE_NAME=8.3.1 ./release-notes-fetcher | tee release_notes.txt
run: set -o pipefail; CAMUNDA_RELEASE_NAME=8.5.1 ./release-notes-fetcher | tee release_notes.txt
env:
GITHUB_CAMUNDA_ACCESS_TOKEN: ${{ steps.generate-camunda-github-token.outputs.token }}
GITHUB_CAMUNDA_CLOUD_ACCESS_TOKEN: ${{ steps.generate-camunda-cloud-github-token.outputs.token }}
10 changes: 7 additions & 3 deletions release-notes-fetcher/fetch.go
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@ import (
const RepoOwner = "camunda"
const CloudRepoOwner = "camunda-cloud"
const MainRepoName = "camunda-platform"
const ZeebeRepoName = "zeebe"
const OperateRepoName = "operate"
const ZeebeRepoName = "camunda"
const OperateRepoName = "camunda"
const TasklistRepoName = "tasklist"
const IdentityRepoName = "identity"
const ReleaseNotesTemplateFileName = "release-notes-template.txt"
Expand Down Expand Up @@ -142,6 +142,10 @@ func main() {
camundaRepoService := camundaGithubClient.Repositories

log.Debug().Msg("Camunda Github ref = " + camundaReleaseVersion)
log.Debug().Msg("Zeebe Github ref = " + camundaAppVersions.Zeebe)
log.Debug().Msg("Tasklist Github ref = " + camundaAppVersions.Tasklist)
log.Debug().Msg("Operate Github ref = " + camundaAppVersions.Operate)
log.Debug().Msg("Identity Github ref = " + camundaAppVersions.Identity)

zeebeReleaseNotes := GetLatestReleaseContents(
ctx,
Expand All @@ -156,7 +160,7 @@ func main() {
RepoOwner,
OperateRepoName,
camundaRepoService,
camundaAppVersions.Operate,
"operate-" + camundaAppVersions.Operate,
)

tasklistReleaseNotesContents := GetChangelogReleaseContents(
Expand Down

0 comments on commit 25b1406

Please sign in to comment.