Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve guidance for subscription correlation key #4833

Open
barmac opened this issue Feb 14, 2025 · 9 comments · May be fixed by #4846
Open

Improve guidance for subscription correlation key #4833

barmac opened this issue Feb 14, 2025 · 9 comments · May be fixed by #4846
Assignees
Labels
enhancement New feature or request needs review Review pending properties panel spring cleaning Could be cleaned up one day ux
Milestone

Comments

@barmac
Copy link
Collaborator

barmac commented Feb 14, 2025

Problem you would like to solve

When I create a message, I see a field called "Subscription correlation key" which is far from being self-explanatory. Yes, there's a link to the documentation on the Message group, but the guidance is needed specifically for the correlation key.

Image

Proposed solution

Add a tooltip to the field so that users get proper guidance.

Alternatives considered

Leave it as is.

Additional context

Slack conversation: https://camunda.slack.com/archives/C0693F1NFK5/p1739458208936919

@barmac barmac added backlog Queued in backlog enhancement New feature or request properties panel spring cleaning Could be cleaned up one day ux labels Feb 14, 2025
@barmac
Copy link
Collaborator Author

barmac commented Feb 14, 2025

This would have to be implemented in bpmn-js-properties-panel.

@abdul99ahad
Copy link
Contributor

What will be the "guidance" in the tooltip?

The correlationKey of a published message can be used to control the process instance creation.

@nikku
Copy link
Member

nikku commented Feb 17, 2025

I'd rephrase to

Use the correlation key to control process instance creation (Learn More)

Important:

  • Controls process instance creation / is complicated enough, so we cannot explain in a tooltip, but link to the source.

@abdul99ahad
Copy link
Contributor

Controls process instance creation / is complicated enough, so we cannot explain in a tooltip, but link to the source.

We can link the resource in Learn More

@abdul99ahad abdul99ahad self-assigned this Feb 17, 2025
@barmac
Copy link
Collaborator Author

barmac commented Feb 17, 2025

I'd rephrase to

Use the correlation key to control process instance creation (Learn More)

Important:

  • Controls process instance creation / is complicated enough, so we cannot explain in a tooltip, but link to the source.

This is coming into the right direction, but in this context the correlation key is used to deliver the message to the right process instance. It does not drive the process instance creation.

@barmac
Copy link
Collaborator Author

barmac commented Feb 17, 2025

Proposal:

Use the correlation key to correlate the message with a process instance (e.g. `= orderId`). [Learn more](https://docs.camunda.io/docs/8.7/components/modeler/bpmn/message-events/#messages).

@nikku
Copy link
Member

nikku commented Feb 17, 2025

Indeed @barmac, you're right in #4833 (comment).

I confused this once again with the behavior when correlating a message to start a process. You cannot define a correlation key there, but the key passed with the message is being used to control instance creation 🙈:

Image

@barmac
Copy link
Collaborator Author

barmac commented Feb 17, 2025

Yes, the correlation key can be passed with a message for instance creation. This is used by Zeebe to prevent duplicate instances, e.g. two process instances initiated for the same orderId (our way to implement idempotence).

@abdul99ahad abdul99ahad added ready Ready to be worked on needs review Review pending and removed backlog Queued in backlog ready Ready to be worked on labels Feb 19, 2025
@nikku nikku added the fixed upstream Requires integration of upstream change label Feb 19, 2025 — with bpmn-io-tasks
@nikku nikku removed the needs review Review pending label Feb 19, 2025
@nikku nikku added this to the M86 milestone Feb 21, 2025
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed fixed upstream Requires integration of upstream change labels Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs review Review pending properties panel spring cleaning Could be cleaned up one day ux
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants