Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: subscription coorelation key tooltip added #1109

Merged
merged 1 commit into from
Feb 20, 2025

Conversation

abdul99ahad
Copy link
Contributor

@abdul99ahad abdul99ahad commented Feb 19, 2025

Related to camunda-modeler: #4833

Proposed Changes

Added tooltip for Subscription correlation key

Screenshot 2025-02-19 at 16 54 43

Checklist

To ensure you provided everything we need to look at your PR:

  • Brief textual description of the changes present
  • Visual demo attached
  • Steps to try out present, i.e. using the @bpmn-io/sr tool
  • Related issue linked via Closes {LINK_TO_ISSUE} or Related to {LINK_TO_ISSUE}

@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Feb 19, 2025
@abdul99ahad abdul99ahad force-pushed the subscription-key-tooltip branch 2 times, most recently from b5ae1e4 to c8ad74e Compare February 19, 2025 16:17
@nikku
Copy link
Member

nikku commented Feb 19, 2025

Not sure if the message brings the point across, what about the following instead:

Key computed from the process context that is used to correlate an incoming message, e.g. = orderId.

@abdul99ahad
Copy link
Contributor Author

Key computed from the process context that is used to correlate an incoming message

Yeah, that sounds about right. If we want to add a little more detail (maybe redundant) we can do this

Key computed from the process context is used to correlate an incoming message ensuring that a message is associated with the correct process instance.

not sure about this though

@nikku
Copy link
Member

nikku commented Feb 20, 2025

I'll keep it short and simple, and go from there.

@barmac
Copy link
Member

barmac commented Feb 20, 2025

As short as I can get it:

Expression result is used to correlate a message with a process instance, e.g. =orderId.

@nikku
Copy link
Member

nikku commented Feb 20, 2025

Expression result is used to correlate a message with a process instance, e.g. =orderId.

My critique is that the result is not used, but instead the result creates an identifier that is used to correlate incoming messages. So most appropriate would be:

Identifier computed from the process context that is used to correlate an incoming message, e.g. = orderId.

@barmac
Copy link
Member

barmac commented Feb 20, 2025

Sounds good to me!

Related to camunda-modeler: #4833
@abdul99ahad abdul99ahad force-pushed the subscription-key-tooltip branch from c8ad74e to 3c4395e Compare February 20, 2025 11:42
@abdul99ahad
Copy link
Contributor Author

Tooltip content changed.
Screenshot 2025-02-20 at 12 43 17

@nikku
Copy link
Member

nikku commented Feb 20, 2025

Good stuff 👏

@abdul99ahad abdul99ahad merged commit bca0ffb into main Feb 20, 2025
9 checks passed
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Feb 20, 2025
@abdul99ahad abdul99ahad deleted the subscription-key-tooltip branch February 20, 2025 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants