-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(guides/spring): configure plaintext for spring SDK #4912
base: main
Are you sure you want to change the base?
Conversation
The spring boot getting started guide uses c8run. C8run does not use ssl / tls Adding the client config to make sure that the SDK can authenticate. fixes to #4911
👋 🤖 ✅ Looks like the changes were ported across versions, nice job! 🎉 You can read more about the versioning within our docs in our documentation guidelines. |
@pepopowitz can you please confirm this is correct by running the guide? We should get this merged and released ASAP if it works as the guide currently doesn't work at all. |
I've asked for a substitute reviewer in our team channel. This is a non-trivial review, and I am desperate to complete my own project this week before cutting a new release makes it harder for me. Though TBH if @meyerdan said that he confirmed these settings in action, I'd trust his word and merge it, and review it when I have more time next week. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran these changes against 8.7.0-alpha3 and 8.6.7 for both the SDK and Camunda Run, and was able to complete the guide in both instances. However, I was also able to complete the guide without the added lines. I'm not terribly familiar with the SDK or its setup, so not sure if that is error on my part, or would be better tested again. I wonder if @jessesimpson36 has any C8Run auth insights? Not sure why it would run fine for me.
However, I went ahead and backported these changes to 8.6 as requested, to speed up approving and merging.
Separately, I ran into a few issues with the 8.7 guide as a whole, and created #4925 to make sure those get addressed.
The spring boot getting started guide uses c8run.
C8run does not use ssl / tls
Adding the client config to make sure that the SDK can authenticate.
fixes to #4911
Description
Should be backported to 8.6
When should this change go live?
bug
orsupport
label)available & undocumented
label)hold
label)low prio
label)PR Checklist
/docs
directory (aka/next/
)./versioned_docs
directory.@camunda/tech-writers
unless working with an embedded writer.