-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate dmn-js@17
/ diagram-js@15
(implicit keyboard binding)
#132
Conversation
Incorporates implicit keyboard / focusable canvas.
deps: bump to dmn-js-properties-panel@3.6.0
I tested this locally, and apparently undo/redo shortcut does not work in dmn-js@17 but it works in dmn-js@16. |
Oh ok, this is due to bpmn-io/dmn-js#920 |
@barmac ready for review. |
CHANGELOG.md
Outdated
|
||
### Breaking Changes | ||
|
||
* Keyboard is now implicit, and canvas is focusable, cf. [bpmn-io/diagram-js#662](https://github.com/bpmn-io/diagram-js/pull/662)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* Keyboard is now implicit, and canvas is focusable, cf. [bpmn-io/diagram-js#662](https://github.com/bpmn-io/diagram-js/pull/662)) | |
* Keyboard is now bound implicitly, and canvas is focusable, cf. [bpmn-io/diagram-js#662](https://github.com/bpmn-io/diagram-js/pull/662)). Calls to `keyboard.bind` and `keyboard.bindTo` now result with a descriptive console error and have no effect. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually not all new calls to bind
will result in an error. Proposed a better message in a4faee3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's update camunda-bpmn-js changelog in that case: https://github.com/camunda/camunda-bpmn-js/blob/main/CHANGELOG.md#breaking-changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be clear: I'd like us to anchor at "do not use these APIs anymore", rather than "you can continue to use them.
I think the old changelog entries + descriptive error on mis-use were OK already. To simplify this message it could read:
* Keyboard is now bound implicitly, and canvas is focusable, cf. [bpmn-io/diagram-js#662](https://github.com/bpmn-io/diagram-js/pull/662)). Attempts to bind the keyboard to an explicit HTML element have no effect.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Giving we have an issue for the limitation from bpmn-io/dmn-js#921 (review), this is ready to merge.
9e3032d
to
a4faee3
Compare
Proposed Changes
Update to latest diagram-js and dmn-js versions.
Incorporates implicit keyboard / focusable canvas.
Child of https://github.com/bpmn-io/internal-docs/issues/1081.
Checklist
To ensure you provided everything we need to look at your PR:
@bpmn-io/sr
toolCloses {LINK_TO_ISSUE}
orRelated to {LINK_TO_ISSUE}