-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: irsa checks #98
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left some smaller comments to look into, nothing critical that has to be fixed in particular, except maybe the null
and mentioning that's helm chart required
.
I tried it out once without any IRSA and once with IRSA on just Postgres.
Overall worked quite well, I was just a bit overwhelmed by the output but I think if someone really uses it to debug, they would appreciate the verbosity.
Hi @Langleu, I've implemented all the item pointed. Thanks in advance! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the additions and resolving my comments.
I didn't try it in detail again since I don't have a setup atm but overall the additions made sense!
Thanks, we will have it running in the tests with https://github.com/camunda/team-infrastructure-experience/issues/378 |
This pull request introduces a substantial script designed to verify IRSA (IAM Roles for Service Accounts) configuration for deployments on Kubernetes.
While the script provides essential functionality, it's important to note that the error handling system is currently somewhat primitive could be nice tp plan to reevaluate it later to improve maintainability (
SCRIPT_STATUS_OUTPUT
).https://github.com/camunda/team-infrastructure-experience/issues/25 associated with this pull request will reference the usage of the script in the documentation. The doc will also include a detailed explanation of using IRSA, the required format for IAM roles, and instructions on how to associate the necessary permissions.
Regarding testing, we plan to integrate c8-sm-checks into our reference architectures https://github.com/camunda/team-infrastructure-experience/issues/378. I have personally tested the script on a reference clusters of eks.