Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: irsa checks #98

Merged
merged 8 commits into from
Nov 7, 2024
Merged

feat: irsa checks #98

merged 8 commits into from
Nov 7, 2024

Conversation

leiicamundi
Copy link
Contributor

@leiicamundi leiicamundi commented Oct 30, 2024

This pull request introduces a substantial script designed to verify IRSA (IAM Roles for Service Accounts) configuration for deployments on Kubernetes.

While the script provides essential functionality, it's important to note that the error handling system is currently somewhat primitive could be nice tp plan to reevaluate it later to improve maintainability (SCRIPT_STATUS_OUTPUT).

https://github.com/camunda/team-infrastructure-experience/issues/25 associated with this pull request will reference the usage of the script in the documentation. The doc will also include a detailed explanation of using IRSA, the required format for IAM roles, and instructions on how to associate the necessary permissions.

Regarding testing, we plan to integrate c8-sm-checks into our reference architectures https://github.com/camunda/team-infrastructure-experience/issues/378. I have personally tested the script on a reference clusters of eks.

@leiicamundi leiicamundi requested a review from Langleu October 30, 2024 18:39
@leiicamundi leiicamundi added the enhancement New feature or request label Oct 30, 2024
@leiicamundi leiicamundi self-assigned this Oct 30, 2024
@leiicamundi leiicamundi marked this pull request as ready for review October 30, 2024 18:39
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
checks/kube/aws-irsa.sh Outdated Show resolved Hide resolved
checks/kube/aws-irsa.sh Outdated Show resolved Hide resolved
Copy link
Member

@Langleu Langleu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some smaller comments to look into, nothing critical that has to be fixed in particular, except maybe the null and mentioning that's helm chart required.

I tried it out once without any IRSA and once with IRSA on just Postgres.

Overall worked quite well, I was just a bit overwhelmed by the output but I think if someone really uses it to debug, they would appreciate the verbosity.

@leiicamundi leiicamundi requested a review from Langleu November 6, 2024 15:12
@leiicamundi
Copy link
Contributor Author

Hi @Langleu,

I've implemented all the item pointed.
Could you please do a 2nd review?

Thanks in advance!

Copy link
Member

@Langleu Langleu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the additions and resolving my comments.

I didn't try it in detail again since I don't have a setup atm but overall the additions made sense!

@leiicamundi
Copy link
Contributor Author

Thanks, we will have it running in the tests with https://github.com/camunda/team-infrastructure-experience/issues/378
I'm merging it and releasing a new version

@leiicamundi leiicamundi merged commit 3c6d739 into main Nov 7, 2024
4 checks passed
@leiicamundi leiicamundi deleted the feature/irsa-checks branch November 7, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants