Remove multiple buttons with same functionality in dev workbench #1068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove duplicate "Choose file" buttons and consolidate functionality in Workbench UI
Summary
This PR removes redundant "Choose file" buttons across the Workbench UI, ensuring a cleaner and more intuitive design. A single "Choose file" button is now shared dynamically between the dataset selection and custom data upload sections. The UI has been refactored to avoid duplication while maintaining all required functionality.
Before:
Multiple "Choose file" buttons appeared across different sections and modals.
Confusion for users due to redundant UI elements.
After:
Only one "Choose file" button dynamically serves all use cases.
Simplified UI improves user experience and reduces visual clutter.
Screenshots:
Before:
After:
Motivation
The previous design had multiple "Choose file" buttons that served the same functionality in different contexts. This redundancy led to a cluttered UI and potential confusion for users. This PR simplifies the interface by consolidating the functionality into a single button that dynamically adapts to its context.
Testing
The changes have been tested by:
Ensuring the "Choose file" button dynamically updates based on the selected context (dataset selection or custom data upload).
Verifying that the selected file is correctly displayed in the corresponding section or modal.
Testing across multiple browsers (Chrome, Firefox, Safari) to ensure consistent functionality.