Refactor for public release #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
se-jaeger
force-pushed
the
refactor-for-public-release
branch
from
db1fd54 to
2523d1f
Compare
se-jaeger
force-pushed
the
refactor-for-public-release
branch
from
2523d1f to
20f2545
Compare
|
So this are my suggestions, @philipp-jung. Please change what does not make sense and/or add what you are missing. |
philipp-jung
approved these changes
Dec 7, 2024
There was a problem hiding this comment.
Great overall improvement and a no-brainer to merge this asap.
Some notes:
- We need some way of keeping track of todos. A great place would be a kanban board in bht-cloud. Github issues are public and often annoying to work with.
- Documentation via the notebooks is fantastic imo. The next step would be to generate documentation from docstrings.
- In terms of next steps of quality of the repo, my list of priorities would be (1) documentation, (2) automated tests, (3) working through other todos in the code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors (more than I have planned) some parts for more consistency within the code base and other ML packages.
It also adds some descriptions and examples to get users started.