Hoist rack-cors into the Gemfile of the starter repo (#1061)

Previously we listed `rack-cors` as a hard dependency in the `core` gems, which meant that application developers were forced to include the gem even if they're not using the api. This makes it possible to remove `rack-cors` from the application completely. Joint PR: bullet-train-co/bullet_train#1954 Fixes: #1050
bullet-train-co · Feb 19, 2025 · 6a7d4a3 · 6a7d4a3
1 parent c427d45
commit 6a7d4a3
Show file tree

Hide file tree

Showing 14 changed files with 0 additions and 36 deletions.
diff --git a/bullet_train-api/Gemfile.lock b/bullet_train-api/Gemfile.lock
@@ -89,7 +89,6 @@ PATH
       jbuilder-schema (~> 2.6.6)
       pagy (~> 8)
       pagy_cursor
-      rack-cors
       rails (>= 6.0.0)
 
 GEM
@@ -325,8 +324,6 @@ GEM
     pwned (2.4.1)
     racc (1.8.1)
     rack (3.1.8)
-    rack-cors (2.0.2)
-      rack (>= 2.0.0)
     rack-protection (4.1.1)
       base64 (>= 0.1.0)
       logger (>= 1.6.0)

diff --git a/bullet_train-api/bullet_train-api.gemspec b/bullet_train-api/bullet_train-api.gemspec
@@ -40,7 +40,6 @@ Gem::Specification.new do |spec|
   spec.add_dependency "rails", ">= 6.0.0"
   spec.add_dependency "pagy", "~> 8"
   spec.add_dependency "pagy_cursor"
-  spec.add_dependency "rack-cors"
   spec.add_dependency "doorkeeper"
   spec.add_dependency "jbuilder-schema", "~> 2.6.6"
   spec.add_dependency "factory_bot"

diff --git a/bullet_train-api/lib/bullet_train/api.rb b/bullet_train-api/lib/bullet_train/api.rb
@@ -8,7 +8,6 @@
 # require "wine_bouncer"
 require "pagy"
 require "pagy_cursor"
-require "rack/cors"
 require "doorkeeper"
 require "scaffolding"
 require "scaffolding/block_manipulator"

diff --git a/bullet_train-api/lib/bullet_train/api/engine.rb b/bullet_train-api/lib/bullet_train/api/engine.rb
@@ -1,5 +1,4 @@
 require "pagy"
-require "rack/cors"
 
 module BulletTrain
   module Api

diff --git a/bullet_train-fields/Gemfile.lock b/bullet_train-fields/Gemfile.lock
@@ -9,7 +9,6 @@ PATH
       jbuilder-schema (~> 2.6.6)
       pagy (~> 8)
       pagy_cursor
-      rack-cors
       rails (>= 6.0.0)
 
 PATH
@@ -334,8 +333,6 @@ GEM
     pwned (2.4.1)
     racc (1.8.1)
     rack (3.1.8)
-    rack-cors (2.0.2)
-      rack (>= 2.0.0)
     rack-protection (4.1.1)
       base64 (>= 0.1.0)
       logger (>= 1.6.0)

diff --git a/bullet_train-incoming_webhooks/Gemfile.lock b/bullet_train-incoming_webhooks/Gemfile.lock
@@ -9,7 +9,6 @@ PATH
       jbuilder-schema (~> 2.6.6)
       pagy (~> 8)
       pagy_cursor
-      rack-cors
       rails (>= 6.0.0)
 
 PATH
@@ -331,8 +330,6 @@ GEM
     pwned (2.4.1)
     racc (1.8.1)
     rack (3.1.8)
-    rack-cors (2.0.2)
-      rack (>= 2.0.0)
     rack-protection (4.1.1)
       base64 (>= 0.1.0)
       logger (>= 1.6.0)

diff --git a/bullet_train-integrations-stripe/Gemfile.lock b/bullet_train-integrations-stripe/Gemfile.lock
@@ -9,7 +9,6 @@ PATH
       jbuilder-schema (~> 2.6.6)
       pagy (~> 8)
       pagy_cursor
-      rack-cors
       rails (>= 6.0.0)
 
 PATH
@@ -357,8 +356,6 @@ GEM
     pwned (2.4.1)
     racc (1.8.1)
     rack (2.2.10)
-    rack-cors (2.0.2)
-      rack (>= 2.0.0)
     rack-protection (3.2.0)
       base64 (>= 0.1.0)
       rack (~> 2.2, >= 2.2.4)

diff --git a/bullet_train-outgoing_webhooks/Gemfile.lock b/bullet_train-outgoing_webhooks/Gemfile.lock
@@ -9,7 +9,6 @@ PATH
       jbuilder-schema (~> 2.6.6)
       pagy (~> 8)
       pagy_cursor
-      rack-cors
       rails (>= 6.0.0)
 
 PATH
@@ -333,8 +332,6 @@ GEM
     pwned (2.4.1)
     racc (1.8.1)
     rack (3.1.8)
-    rack-cors (2.0.2)
-      rack (>= 2.0.0)
     rack-protection (4.1.1)
       base64 (>= 0.1.0)
       logger (>= 1.6.0)

diff --git a/bullet_train-sortable/Gemfile.lock b/bullet_train-sortable/Gemfile.lock
@@ -9,7 +9,6 @@ PATH
       jbuilder-schema (~> 2.6.6)
       pagy (~> 8)
       pagy_cursor
-      rack-cors
       rails (>= 6.0.0)
 
 PATH
@@ -331,8 +330,6 @@ GEM
     pwned (2.4.1)
     racc (1.8.1)
     rack (3.1.8)
-    rack-cors (2.0.2)
-      rack (>= 2.0.0)
     rack-protection (4.1.1)
       base64 (>= 0.1.0)
       logger (>= 1.6.0)

diff --git a/bullet_train-super_scaffolding/Gemfile.lock b/bullet_train-super_scaffolding/Gemfile.lock
@@ -9,7 +9,6 @@ PATH
       jbuilder-schema (~> 2.6.6)
       pagy (~> 8)
       pagy_cursor
-      rack-cors
       rails (>= 6.0.0)
 
 PATH
@@ -325,8 +324,6 @@ GEM
     pwned (2.4.1)
     racc (1.8.1)
     rack (3.1.8)
-    rack-cors (2.0.2)
-      rack (>= 2.0.0)
     rack-protection (4.1.1)
       base64 (>= 0.1.0)
       logger (>= 1.6.0)

diff --git a/bullet_train-themes-light/Gemfile.lock b/bullet_train-themes-light/Gemfile.lock
@@ -9,7 +9,6 @@ PATH
       jbuilder-schema (~> 2.6.6)
       pagy (~> 8)
       pagy_cursor
-      rack-cors
       rails (>= 6.0.0)
 
 PATH
@@ -340,8 +339,6 @@ GEM
     pwned (2.4.1)
     racc (1.8.1)
     rack (3.1.8)
-    rack-cors (2.0.2)
-      rack (>= 2.0.0)
     rack-protection (4.1.1)
       base64 (>= 0.1.0)
       logger (>= 1.6.0)

diff --git a/bullet_train-themes-tailwind_css/Gemfile.lock b/bullet_train-themes-tailwind_css/Gemfile.lock
@@ -9,7 +9,6 @@ PATH
       jbuilder-schema (~> 2.6.6)
       pagy (~> 8)
       pagy_cursor
-      rack-cors
       rails (>= 6.0.0)
 
 PATH
@@ -332,8 +331,6 @@ GEM
     pwned (2.4.1)
     racc (1.8.1)
     rack (3.1.8)
-    rack-cors (2.0.2)
-      rack (>= 2.0.0)
     rack-protection (4.1.1)
       base64 (>= 0.1.0)
       logger (>= 1.6.0)

diff --git a/bullet_train-themes/Gemfile.lock b/bullet_train-themes/Gemfile.lock
@@ -9,7 +9,6 @@ PATH
       jbuilder-schema (~> 2.6.6)
       pagy (~> 8)
       pagy_cursor
-      rack-cors
       rails (>= 6.0.0)
 
 PATH
@@ -328,8 +327,6 @@ GEM
     pwned (2.4.1)
     racc (1.8.1)
     rack (3.1.8)
-    rack-cors (2.0.2)
-      rack (>= 2.0.0)
     rack-protection (4.1.1)
       base64 (>= 0.1.0)
       logger (>= 1.6.0)

diff --git a/bullet_train/Gemfile.lock b/bullet_train/Gemfile.lock
@@ -9,7 +9,6 @@ PATH
       jbuilder-schema (~> 2.6.6)
       pagy (~> 8)
       pagy_cursor
-      rack-cors
       rails (>= 6.0.0)
 
 PATH
@@ -357,8 +356,6 @@ GEM
     pwned (2.4.1)
     racc (1.8.1)
     rack (3.1.8)
-    rack-cors (2.0.2)
-      rack (>= 2.0.0)
     rack-protection (4.1.1)
       base64 (>= 0.1.0)
       logger (>= 1.6.0)