Improvement/59 Make board work with context freezing #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should resolve #59 |
|
I have rebased my changes for this on onto the MOODLE_400_STABLE branch as well |
andreasschenkel
pushed a commit
to andreasschenkel/moodle-mod_board
that referenced
this pull request
Oct 5, 2023
Co-authored-by: Bas Brands <bas@moodle.com>
classes/board.php
Outdated
|
|
||
| $context = static::context_for_board($boardid); | ||
| if (!has_capability('mod/board:post', $context)) { | ||
| // the user is not allowed to post via capabilities. |
There was a problem hiding this comment.
Sorry for this request, but CI checks are god, and they prefer comments starting with capital letters. TIA!
version.php
Outdated
| @@ -25,7 +25,7 @@ | |||
| defined('MOODLE_INTERNAL') || die; | |||
|
|
|||
| $plugin->component = 'mod_board'; // Full name of the plugin (used for diagnostics). | |||
| $plugin->version = 2022040105; // The current module version Use 2022.04.01 as base for 4.00. | |||
| $plugin->version = 2022040106; // The current module version Use 2022.04.01 as base for 4.00. | |||
There was a problem hiding this comment.
Version on main branch is now 2022040111, also release is '1.401.02 (Build 2022040111)';
Hoping to include this in the next release shortly, with some other PRs. TIA!
learningtechnologyservices
requested changes
Mar 7, 2024
|
I have rebased the changes (there was a merge conflict that was not part of the version file in the first commit) I fixed the capitalisation on the comment as part of the rebase. |
|
Eagerly awaiting the split of post and view capabilities :-) |
This is so that when a context is frozen users will still be able to see the contents of the board, but not be able to edit anything.
This is to stop users being able to delete comments in a frozen context
|
Rebased the change |
learningtechnologyservices
approved these changes
Mar 15, 2024
learningtechnologyservices
merged commit 2b6702e
into
brickfield:MOODLE_401_STABLE
3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of this I split the ability to post and rate into a new capability that is separate from the view capability.
I added the new capability into the checks for users being able to edit various features
A also made it so that comments also required the ability for users to make a comment in the first place.
An example of the admin user viewing a board in frozen context with these changes applied:
and the admin user viewing a comment in a frozen board:
