Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust Catalog Selection Logic, Add Filter by Constellation, Fix minor catalog defects #236

Merged
merged 3 commits into from
Jan 21, 2025

Conversation

brickbots
Copy link
Owner

@brickbots brickbots commented Sep 12, 2024

  • Unify catalog selection attributes with filter. schema
  • Make 'Select All/None' select all or no catalog across categories/sub-menus
  • Add filtering by constellation - Present and working, but not exposed in menus.
  • Correct position of M45 in catalog
  • Normalize object type data in catalog
  • Add missing object types to filter selection and obj_type mapping

@brickbots brickbots changed the title WIP: Adjust Catalog Selection Logic and Add Filter by Constellation Adjust Catalog Selection Logic, Add Filter by Constellation, Fix minor catalog defects Jan 21, 2025
@brickbots brickbots merged commit 084f876 into main Jan 21, 2025
2 checks passed
"Pla",
"CM"
],
"filter.constellations": [
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a PR which has a more generic way of filtering, ie you can filter on any attribute of an object - when I get to it again I'll have to refactor, but just a heads up that we don't have to hard code everything

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious what your filter refactor will look like here. Does it operate on the principle of an empty list = all?

It used to be that an empty list (or None) of object types meant 'all', but I'm intentially switching the filtering system away from this as it required multiple exceptions and made the typing a bit strange. Having the explicit list in the default_config is a nice way to know for sure what resetting the filters does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants